Skip to content

convert : fix F32 ftype not being saved #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2023
Merged

convert : fix F32 ftype not being saved #3048

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c0c924
convert : fix F32 ftype not being saved
cebtenzzre Sep 6, 2023
f4a6bbd
convert : check for None explicitly in more places
cebtenzzre Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ def loadOriginalParamsJson(model: LazyModel, config_path: Path) -> Params:
f_rope_freq_base = config["rope_theta"] if "rope_theta" in config else None

# hack to determine LLaMA v1 vs v2 vs CodeLlama
if f_rope_freq_base and f_rope_freq_base == 1000000:
if f_rope_freq_base == 1000000:
# CodeLlama
n_ctx = 16384
elif config["norm_eps"] == 1e-05:
Expand Down Expand Up @@ -841,9 +841,9 @@ def add_meta_arch(self, params: Params) -> None:
name = "LLaMA"

# TODO: better logic to determine model name
if (params.n_ctx == 4096):
if params.n_ctx == 4096:
name = "LLaMA v2"
elif params.path_model:
elif params.path_model is not None:
name = str(params.path_model.parent).split('/')[-1]

self.gguf.add_name (name)
Expand All @@ -856,13 +856,13 @@ def add_meta_arch(self, params: Params) -> None:
self.gguf.add_head_count_kv (params.n_head_kv)
self.gguf.add_layer_norm_rms_eps (params.f_norm_eps)

if params.f_rope_freq_base:
if params.f_rope_freq_base is not None:
self.gguf.add_rope_freq_base(params.f_rope_freq_base)

if params.f_rope_scale:
if params.f_rope_scale is not None:
self.gguf.add_rope_scale_linear(params.f_rope_scale)

if params.ftype:
if params.ftype is not None:
self.gguf.add_file_type(params.ftype)

def add_meta_vocab(self, vocab: Vocab) -> None:
Expand Down