Skip to content

Conversation

cebtenzzre
Copy link
Collaborator

This makes incremental builds quicker, as less objects will need to rebuilt when the git index changes.

Also remove COMMON_H_DEPS from COMMON_DEPS, as this is already implied by common.o's dependency on COMMON_H_DEPS.

@staviq
Copy link
Contributor

staviq commented Oct 29, 2023

Idea:
What if build-info.h defines would get wrapped in functions, in a separate .c file, and compiled into separate .o. This way, only the linker would be triggered on rebuild, and build info values would always be correct, without triggering recompilation of everything?

And
printf("%s\n", BUILD_NUMBER);
would simply become
printf("%s\n", build_info_build_number());

@ggerganov ggerganov merged commit 2046eb4 into ggml-org:master Oct 29, 2023
Nexesenex pushed a commit to Nexesenex/croco.cpp that referenced this pull request Oct 30, 2023
olexiyb pushed a commit to Sanctum-AI/llama.cpp that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants