Skip to content

Conversation

ggerganov
Copy link
Member

cont #5745

Use snake_case for all Python filenames

ggml-ci
@github-actions github-actions bot added documentation Improvements or additions to documentation script Script related examples python python script changes devops improvements to build systems and github actions labels Jul 4, 2024
@ggerganov ggerganov requested a review from compilade July 4, 2024 19:37
Copy link
Collaborator

@compilade compilade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pretty much all occurrences have been found and replaced, but let's wait for CI (especially check-requirements).

Copy link
Contributor

@ditsuke ditsuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All occurrences have been covered afaict, CI passes too now.

@ggerganov ggerganov merged commit e235b26 into master Jul 5, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 7, 2024
* py : switch to snake_case

ggml-ci

* cont

ggml-ci

* cont

ggml-ci

* cont : fix link

* gguf-py : use snake_case in scripts entrypoint export

* py : rename requirements for convert_legacy_llama.py

Needed for scripts/check-requirements.sh

---------

Co-authored-by: Francis Couture-Harpin <git@compilade.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions documentation Improvements or additions to documentation examples python python script changes script Script related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants