Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

point glyphmap creation to relevant functions in cubble #433

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

point glyphmap creation to relevant functions in cubble #433

wants to merge 8 commits into from

Conversation

huizezhang-sherry
Copy link

No description provided.

schloerke
schloerke reviewed Jan 19, 2022
View reviewed changes
DESCRIPTION Outdated Show resolved Hide resolved
DESCRIPTION Outdated Show resolved Hide resolved
R/gglyph.R Outdated Show resolved Hide resolved
R/gglyph.R Outdated Show resolved Hide resolved
R/gglyph.R Outdated Show resolved Hide resolved
R/gglyph.R Outdated Show resolved Hide resolved
huizezhang-sherry and others added 2 commits January 20, 2022 21:44
@huizezhang-sherry
fix review comments
532d44f
@schloerke
Merge branch 'master' into huizezhang-sherry-glyph
52e7ed4 
* master:
  Use `{vdiffr}`; Update GHA; Update "print on CI / examples" method; Fix lints (ggobi#453)
  Fix in `ggcoef_compare()` when using an `include` argument (ggobi#448)
  Fix no_reference_row option in ggcoeff_compare() (ggobi#431)
This was referenced Oct 11, 2022
Closed
Merged
@schloerke
Copy link
Member

@schloerke schloerke marked this pull request as draft October 12, 2022 16:33
@schloerke schloerke mentioned this pull request Oct 12, 2022
Closed
5 tasks
@huizezhang-sherry
Copy link
Author

FYI: still waiting for the dplyr release before cubble can go on CRAN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huizezhang-sherry @schloerke