Display 404 page if banner not found (joomla#20664)

ggppdk · Jun 16, 2018 · fef4b01 · fef4b01
1 parent 129effa
commit fef4b01
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/components/com_banners/models/banner.php b/components/com_banners/models/banner.php
@@ -35,6 +35,13 @@ class BannersModelBanner extends JModelLegacy
 	 */
 	public function click()
 	{
+		$item = $this->getItem();
+
+		if (empty($item))
+		{
+			throw new Exception(JText::_('JERROR_PAGE_NOT_FOUND'), 404);
+		}
+
 		$id = $this->getState('banner.id');
 
 		// Update click count
@@ -55,8 +62,6 @@ public function click()
 			JError::raiseError(500, $e->getMessage());
 		}
 
-		$item = $this->getItem();
-
 		// Track clicks
 		$trackClicks = $item->track_clicks;