Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build 65895 support #60

Merged
merged 2 commits into from
Jun 29, 2018
Merged

Conversation

StoicLoofah
Copy link
Collaborator

With StarCraft 4.4.0, Blizzard shipped a few new event types that required a new reader. Admittedly, I'm not exactly sure what the event is or what this code does with it, but it fixes parsing.

Also bumped the package version to 1.1.0 to account for it.

Could definitely use review from someone.

@StoicLoofah
Copy link
Collaborator Author

Related open question: I have https://github.com/StoicLoofah/spawningtool with a fixed sc2reader==1.0.0, but with the change to sc2reader, I actually don't have to change anything in that library: I just need to bump the required version.

Should I used fixed versions in spawningtool and just increment it with each sc2reader version (e.g. ship spawningtool==2.2.0 for sc2reader==1.1.0), or does it make more sense just to change that to a sc2reader>=1.0.0? Not sure what makes more sense for how people install and update packages and know whether requirements should be updated

@dsjoerg
Copy link
Member

dsjoerg commented Jun 26, 2018

@StoicLoofah I don't see anything obviously amiss in the PR. I think using fixed versions is better so that you can guarantee cross-compatibility.

@StoicLoofah StoicLoofah merged commit cc364ff into ggtracker:upstream Jun 29, 2018
@StoicLoofah StoicLoofah deleted the build_65895_support branch June 29, 2018 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants