IBAN Numbers check failure from various country

[pabx06]

I tryed iban number from diffrents country :
http://www.mobilefish.com/services/random_iban_generator/random_iban_generator.php
they are failling to pass

[ghiscoding]

Hi sorry but I never use the IBAN anywhere, so if you can fix it yourself by doing a pull request then I would be happy. The pattern is located in the validation-rules.js with the rule of
/^[a-zA-Z]{2}\d{2}\s?([0-9a-zA-Z]{4}\s?){4}[0-9a-zA-Z]{2}$/i

So please make a pull request with your fix. Thanks

[ghiscoding]

The only other IBAN Regex I found was the following and is mentioned it's pattern for All IBAN.

[a-zA-Z]{2}[0-9]{2}[a-zA-Z0-9]{4}[0-9]{7}([a-zA-Z0-9]?){0,16}

We don't use IBAN in North America, so I can't help you more.
Please provide feedback if you want this fix.

[pabx06]

Thanks. I will try it tonight . i will let you know . why not include
various iban number from the URL un the test unit ?
Le 15 déc. 2015 20:18, "Ghislain B." notifications@github.com a écrit :

The only other IBAN Regex I found was the following and is mentioned it's
pattern for All IBAN.

[a-zA-Z]{2}[0-9]{2}[a-zA-Z0-9]{4}[0-9]{7}([a-zA-Z0-9]?){0,16}

We don't use IBAN in North America, so I can't help you more.
Please provide feedback if you want this fix.

—
Reply to this email directly or view it on GitHub
#93 (comment)
.

[ghiscoding]

As I mentioned earlier, we actually don't use IBAN in North America where I am. The only reason I had it in my list of Validators is simple because I copied a few of these Validators from another tool and the IBAN was in there. I never ever used IBAN and don't know at all how it works.

So if you have a proper Regex for it, then please provide, if not I might end up removing it completely from the available Validators. I never used it and will never use it... so it's all in your hand ;)

And quickly looking at it, we might actually not be able to have a Regex to fit all, since that seems to change from each country as displayed in this web page: IBAN/BBAN Regular Expression Patterns

[pabx06]

Yes but it has à checksum. Like credit card . il will try to make send a
patch. IBAN is replacing crédit card un popularity un europe. And has lower
fée.
Le 15 déc. 2015 22:18, "Ghislain B." notifications@github.com a écrit :

As I mentioned earlier, we actually don't use IBAN in North America where
I am. The only reason I had it in my list of Validators is simple because I
copied a few of these Validators from another tool and the IBAN was in
there. I never ever used IBAN and don't know at all how it works.

So if you have a proper Regex for it, then please provide, if not I might
end up removing it completely from the available Validators. I never used
it and will never use it... so it's all in your hand ;)

And quickly looking at it, we might actually not be able to have a Regex
to fit all, since that seems to change from each country as displayed in
this web page: IBAN/BBAN Regular Expression Patterns
http://ht5ifv.serprest.pt/extensions/tools/IBAN/

—
Reply to this email directly or view it on GitHub
#93 (comment)
.

[ghiscoding]

The problem is that for my Validator to work, it needs to be a Regex pattern, and if you can't do it via a Regex then it won't work. I don't see any ways of dealing with a checksum inside a Regex.

The other option you might have is through a custom javascript function, but you will have to do it on your own.

Do you speak French? Moi oui...

[pabx06]

Le problème j'aimerais bien intégré l'IBAN BIC dans ce projet.

bower install iban. et ou npm install iban

var IBAN=require('iban');

console.log(IBAN.isValid('BE68539007547034')); // true
console.log(IBAN.isValid('AL66565657692576393682655152'));

apres http://browserify.org/

sinom installer un autre projet : https://github.com/mmjmanders/ng-iban

j'abandonne j'ai pas reussit a installer dans ton code

2015-12-15 23:26 GMT+01:00 Ghislain B. notifications@github.com:

The problem is that for my Validator to work, it needs to be a Regex
pattern, and if you can't do it via a Regex then it won't work. I don't see
any ways of dealing with a checksum inside a Regex.

The other option you might have is through a custom javascript function
https://github.com/ghiscoding/angular-validation/wiki/Custom-Validation-functions,
but you will have to do it on your own.

Do you speak French? Moi oui...

—
Reply to this email directly or view it on GitHub
#93 (comment)
.

[ghiscoding]

Tu peux utiliser ton outil IBAN externe en passant par Angular-Validation custom et tu peux aussi ajouter d'autres Validateurs comme par exemple required

<input type="text" class="form-control"
            name="iban"
            ng-model="vm.model.iban"
            validation="custom:vm.myIbanCheck(vm.model.iban)|required" />

Ensuite dans ton controller, appelle ta fonction custom

myApp.controller('Ctrl', function () {
    var vm = this;

    vm.myIbanCheck = function(inputModel) {
         return IBAN.isValid(inputModel);
    }
}

Je n'ai pas tester mais ça devrait fonctionner. Dis-moi si ça fonctionne et ensuite je l'ajouterai dans la documentation Wiki.

[pabx06]

je suis de strasbourg. je vais checker. a plus . c'est rare les gens qui
font de l'angular en france

Le 17 décembre 2015 à 16:07, Ghislain B. notifications@github.com a écrit
:

Tu peux utiliser ton outil IBAN externe en passant par Angular-Validation
custom et tu peux aussi ajouter d'autres Validateurs comme par exemple
required

Ensuite dans ton controller, appelle ta fonction custom

myApp.controller('Ctrl', function () {
var vm = this;

vm.myIbanCheck = function(inputModel) {
     return IBAN.isValid(inputModel);
}

}

Je n'ai pas tester mais ça devrait fonctionner. Dis-moi si ça fonctionne
et ensuite je l'ajouterai dans la documentation Wiki.

—
Reply to this email directly or view it on GitHub
#93 (comment)
.

[ghiscoding]

Je suis de Montréal, j'ai juste vu que tu avais mis beaucoup d'accents alors j'ai imaginé que tu parlais Français :P

Je suis pratiquement certain qu'en utilisant le custom, tu arriveras a une solution. Fais-moi savoir si c'est bon, merci.

[ghiscoding]

Est-ce que ca fonctionne? J'aimerais pouvoir fermer ce ticket...

[pabx06]

J'ai pas encore testé mais c'est pas mal lourd , mon app . et j'ai une
erreur avec angular après minification de l'App uniquement je pense que ça
provient du service de traduction ...
Le 23 déc. 2015 06:31, "Ghislain B." notifications@github.com a écrit :

Est-ce que ca fonctionne? J'aimerais pouvoir fermer ce ticket...

—
Reply to this email directly or view it on GitHub
#93 (comment)
.

[ghiscoding]

For IBAN validation, I now suggest to use Wiki - Custom Validation with the external library of Github - arhs/iban.js.

I updated the Custom Validation - Plunker Demo and also the code sample found under the folder more-examples/customValidation

Merci de ton support, mes pages Wiki sont a jour sur le sujet :)