feat: add tabindex to list item to control up/down arrow direction #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ghiscoding
commented
Nov 25, 2023
ghiscoding
commented
- add tabIndex on every list item and select-all checkbox so that we can use up/down arrows to focus on next or previous item.
- divider will be skipped and ignored
- using Enter or Space key will select/unselect the input checkbox of the current item
- add tabIndex on every list item and select-all checkbox so that we can use up/down arrows to focus on next or previous item. - divider will be skipped and ignored - using Enter or Space key will select/unselect the input checkbox of the current item
🎭 Playwright Summary - Success 🎉Playwright Report
Running 69 tests using 2 workers |
- when using VirtualScroll, it recreates the dropdown list and we need to unbind previous listeners and rebind new listener, also when the list gets recreated then we also need to refocus on the same item but in the new list - add group name to unbindAll to easily unbind events when dealing with VirtualScroll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.