Skip to content

fix: add aria-expanded on ms-drop element, fixes #178 #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2023
Merged

fix: add aria-expanded on ms-drop element, fixes #178 #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/src/MultipleSelectInstance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,11 @@ export class MultipleSelectInstance {
this.choiceElm.appendChild(createDomElement('div', { className: 'icon-caret' }));

// default position is bottom
this.dropElm = createDomElement('div', { className: `ms-drop ${this.options.position}` }, this.parentElm);
this.dropElm = createDomElement(
'div',
{ className: `ms-drop ${this.options.position}`, ariaExpanded: 'false' },
this.parentElm
);

// add data-name attribute when name option is defined
if (name) {
Expand Down Expand Up @@ -446,6 +450,7 @@ export class MultipleSelectInstance {
if (!dropVisible) {
this.dropElm.style.left = '-10000';
this.dropElm.style.display = 'block';
this.dropElm.ariaExpanded = 'true';
}

const updateDataOffset = () => {
Expand Down Expand Up @@ -479,6 +484,7 @@ export class MultipleSelectInstance {
if (!dropVisible) {
this.dropElm.style.left = '0';
this.dropElm.style.display = 'none';
this.dropElm.ariaExpanded = 'false';
}
} else {
if (this.ulElm) {
Expand Down Expand Up @@ -992,6 +998,7 @@ export class MultipleSelectInstance {
this.parentElm.classList.add('ms-parent-open');
this.choiceElm?.querySelector('div')?.classList.add('open');
this.dropElm.style.display = 'block';
this.dropElm.ariaExpanded = 'true';

if (this.selectAllElm?.parentElement) {
this.selectAllElm.parentElement.style.display = 'block';
Expand Down Expand Up @@ -1083,6 +1090,7 @@ export class MultipleSelectInstance {
this.parentElm.classList.remove('ms-parent-open');
this.choiceElm?.querySelector('div')?.classList.remove('open');
this.dropElm.style.display = 'none';
this.dropElm.ariaExpanded = 'false';

if (this.options.container) {
this.parentElm.appendChild(this.dropElm);
Expand Down