Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #155: Updated ghostbsd-version and pkg config for package base #327

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Jun 30, 2024

Summary by Sourcery

This pull request updates the ghostbsd-version script to query the 'GhostBSD-runtime' package instead of 'os-generic-userland-base', ensuring the correct package version is retrieved.

  • Enhancements:
    • Updated the package query in ghostbsd-version.sh to use 'GhostBSD-runtime' instead of 'os-generic-userland-base'.

@ericbsd ericbsd linked an issue Jun 30, 2024 that may be closed by this pull request
Copy link

sourcery-ai bot commented Jun 30, 2024

Reviewer's Guide by Sourcery

This pull request addresses Issue #155 by updating the ghostbsd-version script to query the correct package for the OS version. Specifically, it changes the package queried from 'os-generic-userland-base' to 'GhostBSD-runtime'.

File-Level Changes

Files Changes
bin/ghostbsd-version/ghostbsd-version.sh Updated the ghostbsd-version script to query the 'GhostBSD-runtime' package instead of 'os-generic-userland-base' for the OS version.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@ericbsd ericbsd self-assigned this Jun 30, 2024
@ericbsd ericbsd requested review from a team and removed request for a team June 30, 2024 18:29
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ericbsd ericbsd merged commit 0445c68 into stable/14 Jul 3, 2024
4 checks passed
@ericbsd ericbsd deleted the 155-add-pkgbase-support-in-etcpkgghostbsdconf branch July 3, 2024 11:44
@ericbsd ericbsd added the task label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add pkgbase support in /etc/pkg/GhostBSD.conf
1 participant