Lint adblocker/tools

packages/adblocker/package.json

@@ -24,7 +24,7 @@
   },
   "scripts": {
     "clean": "rimraf dist coverage",
-    "lint": "eslint src adblocker.ts",
+    "lint": "eslint src tools adblocker.ts",
     "build": "tsc --build ./tsconfig.json",
     "bundle": "tsc --build ./tsconfig.bundle.json && rollup --config ./rollup.config.ts --configPlugin typescript",
     "prepack": "yarn run bundle",

packages/adblocker/tools/generate_compression_codebooks.ts

@@ -86,6 +86,7 @@ function validateCodebook(codebook: string[], strings: string[]): void {
     const compressed = smaz.compress(str);
     const original = smaz.decompress(compressed);
     if (original !== str) {
+      // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
       throw new Error(`Mismatch: ${str} vs. ${original} (compressed: ${compressed})`);
     }
 

packages/adblocker/tools/priorities.ts

@@ -164,7 +164,7 @@ async function loadAllLists(): Promise<string> {
     }
   }
 
-  for (const [name, count] of unsupported.entries().sort(([_1, c1], [_2, c2]) => c2 - c1)) {
+  for (const [name, count] of unsupported.entries().sort(([, c1], [, c2]) => c2 - c1)) {
     console.log(`+ ${name} = ${count}`);
   }
 

packages/adblocker/tools/stress-test-engine-update.ts

@@ -70,7 +70,8 @@ function replacer(option: string): string {
  * example `||foo.com$stylesheet,first-party,xhr` would be normalized to
  * `||foo.com$css,1p,xhr`.
  */
-const REGEX = /third-party|first-party|object-subrequest|stylesheet|subdocument|xmlhttprequest|document/g;
+const REGEX =
+  /third-party|first-party|object-subrequest|stylesheet|subdocument|xmlhttprequest|document/g;
 function normalizeFilters(rawFilter: string): string {
   if (rawFilter.startsWith('|http*://$')) {
     rawFilter = rawFilter.slice(9);
@@ -183,7 +184,7 @@ async function getRevision(url: string): Promise<string> {
     return cached;
   }
 
-  let data = (await axios.get(url)).data;
+  let data: string = (await axios.get(url)).data;
   if (!data.startsWith('[Ad')) {
     const buffer = Buffer.from(
       (
@@ -272,6 +273,7 @@ async function collectTestCases(list: string): Promise<TestCase[]> {
   const revisions: Set<string> = new Set();
 
   // Append current revision (the most recent one)
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
   const previousRevisions = [...meta.revisions];
   console.log('revisions', previousRevisions);
 

packages/adblocker/tsconfig.json

@@ -11,6 +11,8 @@
   ],
   "include": [
     "./src/**/*.ts",
+    "./tools/**/*.ts",
+    "./test/**/*.ts",
     "./adblocker.ts"
   ]
 }