Fix missing 'domcontentloaded' event listener removal from disableBlockingInPage
#1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remusao
requested changes
May 3, 2021
|
Thanks! The fix looks good, I had a few comments related to tests and some changes which do not seem related to the issue at hand. |
|
Regarding the tests, @Tyler-Murphy has added a setup with local http server in another PR #1885, which maybe we can reuse here to test the fix for CSS injection. What do you think? |
|
Oh sorry, I hadn't noticed your suggestion regarding the tests and invented my own bicycle :D |
remusao
reviewed
May 4, 2021
remusao
approved these changes
May 4, 2021
remusao
changed the title
disableBlockingInPage
|
Thanks a lot for this fix @kmosunoff, much appreciated! The change will be released shortly. |
|
Thank you @remusao for your attention and reviews! |
|
Released as v1.20.5 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.