Add matchDebug() for Cliqz #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjethani
force-pushed
the
add-ubo-matchdebug
branch
from
cbcfff5 to
ec7ea79
Compare
mjethani
changed the title
|
Sorry I just noticed #2160. I have made this only for Cliqz now. |
remusao
reviewed
Aug 12, 2021
| url, | ||
| sourceUrl: frameUrl, | ||
| type, | ||
| })).filter || null; |
There was a problem hiding this comment.
By default the original filter might not be kept around (but the engine will try to recreate it from internal state. If we know we are in debug mode we can specify it to the FiltersEngine.parse method above:
static parse(rawLists, enableCompression, debug) {
return new Cliqz(FiltersEngine.parse(rawLists, {
enableCompression,
integrityCheck: false,
loadCosmeticFilters: false,
debug: debug === true,
}));
}
remusao
reviewed
Aug 12, 2021
| url, | ||
| sourceUrl: frameUrl, | ||
| type, | ||
| })).filter || null; |
There was a problem hiding this comment.
Also I think filter will be an object and not sure if the toString() will be called implicitly somewhere? If not:
Suggested change
| })).filter || null; | |
| })).filter?.toString() || null; |
There was a problem hiding this comment.
Now I'm returning the value of rawLine or null.
mjethani
force-pushed
the
add-ubo-matchdebug
branch
from
ec7ea79 to
bf3c8f0
Compare
mjethani
force-pushed
the
add-ubo-matchdebug
branch
from
bf3c8f0 to
0737917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a
matchDebug()implementation for Cliqz.