Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Puppeteer Cooperative Intercept Mode #2343

Merged
merged 2 commits into from
Dec 11, 2021
Merged

Update Puppeteer Cooperative Intercept Mode #2343

merged 2 commits into from
Dec 11, 2021

Conversation

FdezRomero
Copy link
Contributor

@FdezRomero FdezRomero commented Dec 10, 2021 •
edited
Loading

Updates #2281 with:

  • Puppeteer v13.0.0
  • New check for already handled requests in Legacy Mode
  • Fix for breaking changes with continueRequestOverrides()

Related to berstend/puppeteer-extra#592

@FdezRomero FdezRomero requested a review from remusao as a code owner December 10, 2021 18:57
@FdezRomero FdezRomero mentioned this pull request Dec 10, 2021
Merged
benallfree
benallfree approved these changes Dec 10, 2021
View reviewed changes
Copy link

@benallfree benallfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@remusao remusao added the PR: Bug Fix 🐛 Increment patch version when merged label Dec 11, 2021
remusao
remusao approved these changes Dec 11, 2021
View reviewed changes
Copy link
Collaborator

@remusao remusao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for taking the time to make a PR with all these improvements.

@remusao remusao merged commit cb507b8 into ghostery:master Dec 11, 2021
@remusao remusao mentioned this pull request Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remusao remusao remusao approved these changes

@benallfree benallfree benallfree approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛 Increment patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FdezRomero @benallfree @remusao