Re-Implemented Geo Level for in memory, increased performance #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because {} depends on clustering_google_maps from git which depends on path_provider ^1.1.0, path_provider ^1.1.0 is required.
So, because lists_polls depends on path_provider ^2.0.1, version solving failed.
pub get failed (1; So, because lists_polls depends on path_provider ^2.0.1, version solving failed.)
Because every version of clustering_google_maps from git depends on google_maps_flutter ^1.0.3 and {} depends on google_maps_flutter ^2.0.1, clustering_google_maps from git is forbidden.
So, because {} depends on clustering_google_maps from git, version solving failed.
pub get failed (1; So, because lists_polls depends on clustering_google_maps from git, version solving failed.)
Error: Method not found: 'BitmapDescriptor.fromAsset'.
BitmapDescriptor.fromAsset(bitmapAssetPathForSingleMarker);
Removed prints in debug mode
restoring line
… the array of markers at init time and caching previous results based on zoom level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have reviewed this repo:
onTapfunctions work, and BitmapDescriptors.===> this avoids the nested for loop in [2]. Nested because it is a for loop in a recursive function.
===> With the input sorted it is only necessary O(n) to generate all the markers in one go.
Let me know if this work for you and what not and I can rearrange the commits so you can add the PR.
[1]
clustering_google_maps/lib/src/clustering_helper.dart
Line 139 in ce69f59
[2]
clustering_google_maps/lib/src/clustering_helper.dart
Line 209 in ce69f59