migrate from dep to Go modules

[QuentinBisson]

Hello team, I created this as a draft as I wanted to make sure we could test it before merging.

Do you know how we could do that? The gen script works as I clone the code generator on every run.

WDYT?

[QuentinBisson]

@tfussell That is awesome :) Thanks for finding that out :) I think we can change that to a true PR

[rossf7]

@tfussell Nice. 🎉❤️

[tfussell]

@tfussell Nice. 🎉❤️

Thanks. I was going to see if I could come up with some flags for generate-groups.sh that would allow me to skip the ugly cp and rm steps at the end (the output is in the scripts/ directory instead of in-place), but it's a start.

Should we target v0.17.1?

On the one hand it would be nice to do everything in a big push like with 1.16 and Helm 2.16, but on the other it would be nice to minimize the number of changes to keep this self-contained. If we could switch everything to go modules separately from updating K8s and Helm, I sort of feel like we should try to do it. Maybe we should discuss in the WG.

[MarcelMue]

I am also in favour of moving any projects we can to go modules already. Question for me would be if importing apiextensions like this already works for dep projects?

[QuentinBisson]

We can vendor using go mod vendor.
So maybe we need to see if we can keep the vendor directory for dep to work while having go modules?

Otherwise, it seems people are using this PR of helm golang/dep#1963

[kopiczko]

go mod vendor won't help. vendor directory of dependencies isn't used.

We can keep Gopkg.{toml,lock} for a while.

[rossf7]

Another 2 cents from me. The big bang approach sucks and for me is a last resort.

We can keep Gopkg.{toml,lock} for a while.

If we can do this for dep compatibility and merge stuff sooner with K8s 1.16.6 that is fine with me. 👍

[tfussell]

We can keep Gopkg.{toml,lock} for a while.

This seems like the way to go as long as we don't forget to keep them in sync. Maybe try to switch to go modules iteratively in 1.16 and then get rid of Gopkg.{toml,lock} in 1.17?

[MarcelMue]

I think the only thing missing here before merging is creating the release of this library as outlined by pawel here:
https://github.com/giantswarm/giantswarm/issues/9192

[kopiczko]

I'd like to have a changelog and release v0.1.0 before merging this.

[tfussell]

Changelog is created. Waiting for a few small changes to some CRDs before creating the 0.1.0 release.

[xh3b4sd]

Hi gang, I wanna push this over the finish line. Thanks for the hard work so far already. 🚀

[rossf7]

@xh3b4sd Hey, I needed to merge #364 because its blocking me in app-operator and chart-operator.

I'm about to release 0.1.2 just waiting on CI.

[rossf7]

@xh3b4sd OK done. Thx!