Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate junit report so that sonobuoy parses the result #20

Merged
merged 21 commits into from
Jan 28, 2021
Merged

Generate junit report so that sonobuoy parses the result #20

merged 21 commits into from
Jan 28, 2021

Conversation

fiunchinho
Copy link
Member

@fiunchinho fiunchinho commented Jan 27, 2021 •
edited
Loading

We need to install:

  • tool to generate junit report from go test output, because that's what sonobuoy understands.
  • nodejs tool to merge together different junit reports, because we generate one for the deletion test and one for the rest.

@fiunchinho fiunchinho marked this pull request as ready for review January 28, 2021 12:19
@fiunchinho fiunchinho requested a review from a team January 28, 2021 12:20
@fiunchinho fiunchinho changed the title Always exit 1 Generate junit report so that sonobuoy parses the result Jan 28, 2021
@fiunchinho
Copy link
Member Author

Going with a ping, but I'm interested in your feedback if you have.

@fiunchinho fiunchinho merged commit b1aabef into master Jan 28, 2021
@fiunchinho fiunchinho deleted the always-exit-1 branch January 28, 2021 12:30
tuommaki
tuommaki reviewed Jan 28, 2021
View reviewed changes
Copy link
Contributor

@tuommaki tuommaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuommaki tuommaki tuommaki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiunchinho @tuommaki