Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guernsey mobile numbers report location as United States #37

Closed
AllenJB opened this issue Aug 14, 2014 · 3 comments
Closed

Guernsey mobile numbers report location as United States #37

AllenJB opened this issue Aug 14, 2014 · 3 comments

Comments

@AllenJB
Copy link

AllenJB commented Aug 14, 2014

Test number: 447839123456
Default location: GB

Related to #36 / #17?

(PS. Sorry, just found this additional one in our DB and you'd already fixed #36)
@giggsey
Copy link
Owner

giggsey commented Aug 14, 2014

Haha, okay, I'm not going to fix this one straight away. I'm going to try to find out how to resolve the root cause.

If you need it, you can follow something similar to the commit I did in #36.

@AllenJB
Copy link
Author

AllenJB commented Aug 14, 2014

No worries. This isn't urgent for us. And fixing the root issue is always good.

Thanks for this port and your awesome response times for these issues. =D

@giggsey giggsey mentioned this issue Aug 22, 2014
Merged
@giggsey
Copy link
Owner

giggsey commented Aug 22, 2014

Okay, I think I've implemented a better fix (part of 6.2.2).

I didn't add as a unit test, but I have just checked on the demo, and it reports Guernsey correctly now.

@giggsey giggsey closed this as completed Aug 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giggsey @AllenJB