Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fasthttp or fasthttprouter #498

Closed
valyala opened this issue Dec 16, 2015 · 31 comments
Closed

Add support for fasthttp or fasthttprouter #498

valyala opened this issue Dec 16, 2015 · 31 comments
Assignees
Milestone

Comments

@valyala
Copy link

valyala commented Dec 16, 2015

Fasthttp provides an http server optimized for high performance. It doesn't allocate memory in hot paths - the same approach is used by httprouter.

With fasthttp gin may become even faster. See also fasthttprouter, httprouter fork based on fasthttp.

@nkev
Copy link

nkev commented Jan 3, 2016

@valyala This would be great, but even greater would be a @valyala powered middleware project that incorporates fasthttp and fasthttprouter and comes with lots of middleware (conversions from existing middleware). If done elegantly, I think it might even become the standard.

@oharlem
Copy link

oharlem commented Jan 13, 2016

+1

@manucorporat
Copy link
Contributor

@valyala @mpmlj @nkev I am going to evaluate it this week!

@night-codes
Copy link

👍

@slinso
Copy link

slinso commented Feb 22, 2016

Hi @manucorporat ,

will v2 be based on fasthttp? I guess so, because of your speed improvements mentioned in another issue.
I would be really glad if I could help you with the transition.

@javierprovecho
Copy link
Member

@slinso hi there,

We are looking forward creating a plug able interface for http compliant packages such as fast http.

@slinso
Copy link

slinso commented Feb 23, 2016

@javierprovecho
Ok, sounds nice! https://github.com/labstack/echo/blob/v2/engine/engine.go looks like the same idea.

@EwanValentine
Copy link

This is a fantastic idea! Imagine Gin's speed on fasthttp... +1

@Huangsir
Copy link

+1

@valyala
Copy link
Author

valyala commented Feb 26, 2016

See also fasthttp-routing from Yii author.

@nkev
Copy link

nkev commented Mar 8, 2016

@manucorporat any news on your fasthttp evaluation?

@otraore
Copy link

otraore commented Mar 14, 2016

+1

1 similar comment
@dxvgef
Copy link

dxvgef commented Mar 15, 2016

+1

@liuzc
Copy link

liuzc commented Apr 3, 2016

+1
Echo can run with FastHTTP server now.

@otraore
Copy link

otraore commented Apr 7, 2016

Any updates on this? @manucorporat

@javierprovecho
Copy link
Member

@otraore as I told you on gitter, let me try to make an experimental version of gin with fasthttp, this weekend on my spare time 😉

@javierprovecho javierprovecho self-assigned this Apr 9, 2016
@otraore
Copy link

otraore commented Apr 9, 2016

@javierprovecho Good to hear! thats great news! Maybe add the milestone v2 to this issue?

@appleboy
Copy link
Member

appleboy commented Apr 9, 2016

Great news!! 👍

@javierprovecho
Copy link
Member

@otraore that was too good, fasthttp is not what I though. It doesn't compensate the effort of moving every aspect of gin v1 to fasthttp because of how different it is. Definitely I'm going to create the v2 milestone, but this is going to take some more time than just a weekend.

(I started a "fasthttp" branch, however it is not functional 😴 I'll keep watching it next week)

@javierprovecho
Copy link
Member

I think I'm going to follow the path @manucorporat did sometime, forking fasthttprouter and evolving it to gin-fast or something similar...

@javierprovecho javierprovecho added this to the v2 milestone Apr 14, 2016
@Huangsir
Copy link

+1

@jbub
Copy link

jbub commented Dec 28, 2016

Note that echo author decided to drop fasthttp support to bring back simplicity for echo v3 labstack/echo#665. Maybe this can help with some decisions.

@appleboy
Copy link
Member

Yes, everybody can refer release note for echo v3.

@rebootcode
Copy link

gin will not use fasthttprouter ?

@appleboy
Copy link
Member

appleboy commented Jul 2, 2017

@rebootcode No.

@rebootcode
Copy link

#498 (comment)

No as ( It will use ) or ( It will not use ) ?

@appleboy
Copy link
Member

appleboy commented Jul 2, 2017

as @jbub comments.

Note that echo author decided to drop fasthttp support to bring back simplicity for echo v3 labstack/echo#665. Maybe this can help with some decisions.

I think we don't support fasthttprouter in the future.

@appleboy
Copy link
Member

appleboy commented Jul 2, 2017

@javierprovecho @tboerger What is your thoughts?

@tboerger
Copy link
Contributor

tboerger commented Jul 2, 2017

I personally don't want to support it. It got some downsides like workarounds, no http2... Just to mention 2 reasons.

@kolomiichenko
Copy link

👍

@javierprovecho
Copy link
Member

no plans for near future, last time i checked fast http breaks a lot of features gin rely on.

closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests