-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for fasthttp or fasthttprouter #498
Comments
+1 |
👍 |
Hi @manucorporat , will v2 be based on fasthttp? I guess so, because of your speed improvements mentioned in another issue. |
@slinso hi there, We are looking forward creating a plug able interface for http compliant packages such as fast http. |
@javierprovecho |
This is a fantastic idea! Imagine Gin's speed on fasthttp... +1 |
+1 |
See also fasthttp-routing from Yii author. |
@manucorporat any news on your fasthttp evaluation? |
+1 |
1 similar comment
+1 |
+1 |
Any updates on this? @manucorporat |
@otraore as I told you on gitter, let me try to make an experimental version of gin with fasthttp, this weekend on my spare time 😉 |
@javierprovecho Good to hear! thats great news! Maybe add the milestone v2 to this issue? |
Great news!! 👍 |
@otraore that was too good, fasthttp is not what I though. It doesn't compensate the effort of moving every aspect of gin v1 to fasthttp because of how different it is. Definitely I'm going to create the v2 milestone, but this is going to take some more time than just a weekend. (I started a "fasthttp" branch, however it is not functional 😴 I'll keep watching it next week) |
I think I'm going to follow the path @manucorporat did sometime, forking |
+1 |
Note that |
Yes, everybody can refer release note for echo v3. |
gin will not use fasthttprouter ? |
@rebootcode No. |
No as ( It will use ) or ( It will not use ) ? |
as @jbub comments.
I think we don't support fasthttprouter in the future. |
@javierprovecho @tboerger What is your thoughts? |
I personally don't want to support it. It got some downsides like workarounds, no http2... Just to mention 2 reasons. |
👍 |
no plans for near future, last time i checked fast http breaks a lot of features gin rely on. closing |
Fasthttp provides an http server optimized for high performance. It doesn't allocate memory in hot paths - the same approach is used by httprouter.
With fasthttp gin may become even faster. See also fasthttprouter, httprouter fork based on fasthttp.
The text was updated successfully, but these errors were encountered: