Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use white color for HTTP 1XX #3741

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

viralparmarme
Copy link
Contributor

Fixes #3728

@viralparmarme
Copy link
Contributor Author

@appleboy @herrberk @adrianosela @thinkerou @fabricioereche
Please review this minor but super important fix... thanks!

@maggie44
Copy link

LGTM

@appleboy appleboy added this to the v1.10 milestone Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c2ba8f1) 99.20% compared to head (b521f33) 99.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3741   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          42       42           
  Lines        3157     3159    +2     
=======================================
+ Hits         3132     3134    +2     
  Misses         17       17           
  Partials        8        8           
Flag Coverage Δ
99.20% <100.00%> (+<0.01%) ⬆️
go-1.18 99.11% <100.00%> (+<0.01%) ⬆️
go-1.19 99.20% <100.00%> (+<0.01%) ⬆️
go-1.20 99.20% <100.00%> (+<0.01%) ⬆️
macos-latest 99.20% <100.00%> (+<0.01%) ⬆️
ubuntu-latest 99.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
logger.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appleboy appleboy merged commit a481ee2 into gin-gonic:master Sep 27, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging colour for < 200 should be white?
5 participants