-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ShouldBindBodyWith shortcut and change doc #3871
Conversation
I looked it up, and Red Hat says that YAML is a superset of JSON, and all the data can be parsed in JSON format. In issue , a user told me that parsing is normal behavior I set out to fix the test case. |
Hello, please take a look at the PR I submitted and give me some feedback. This PR provides 4 types of shortcuts to ShouldBindBodyWith, which are JSON, YAML, XML, and TOML. Take a look at this PR, please. @appleboy @thinkerou @manucorporat |
I will take a look. |
@RedCrazyGhost Please help to fix lint error. |
@appleboy Thanks for your help, I am trying to fix the error in lint, I have committed fix commit. |
Hello, can you help me start the approval flow? @flc1125 |
I'm not a project member and can't help you. Thanks~ |
Okay, I see. Sorry to bother you. |
@appleboy Hello, please approve the workflow if you have time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3871 +/- ##
==========================================
- Coverage 99.21% 99.18% -0.03%
==========================================
Files 42 43 +1
Lines 3182 2709 -473
==========================================
- Hits 3157 2687 -470
+ Misses 17 12 -5
- Partials 8 10 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Do I need to pay attention to the CodeCov bot detection report? Adding new method shortcuts results in a substantial drop in coverage. |
This codecov detection result is not the same as the result of go test coverage. This makes me very confused! I don't know how to solve this patch coverage? @appleboy termial use code: $ go test -coverprofile=coverage.out ./... $ go tool cover -html=coverage.out |
@RedCrazyGhost I've checked the tests myself, so I won't refer to the data from codecov. :) Thanks. |
Thank you for your support throughout. |
Resolves #3823
Based on this #3823 proposal, I code about shortcuts
Ran into an issue like #3862 during testing
I hope to get some help.
This is my first time submitting code in open source。