Update Python and Django versions #65
Conversation
adamchainz
force-pushed
the
upgrade_versions
branch
from
760291c
to
4727e8d
Compare
| python-version: | ||
| - '3.8' | ||
| - '3.9' | ||
| - '3.10' | ||
| - '3.11' | ||
| - '3.12' |
There was a problem hiding this comment.
one per line reduces diff noise for future removals/additions
| basepython = | ||
| py36: python3.6 | ||
| py37: python3.7 | ||
| py38: python3.8 | ||
| py39: python3.9 | ||
| py310: python3.10 |
There was a problem hiding this comment.
I don't think this was ever needed, tox knows how to pick the python version by default. (Maybe a really old tox version needed it?)
There was a problem hiding this comment.
I think this is artifact from of old TravisCI or Tox versions.
You've confirmed that py3X automatically maps to python3.X locally?
| flake8 | ||
| isort | ||
| py38-django{32,40,41,42} | ||
| py39-django{32,40,41,42} | ||
| py310-django{32,40,41,42,50,main} | ||
| py311-django{41,42,50,main} | ||
| py312-django{42,50,main} |
There was a problem hiding this comment.
Switched to the django prefix that other projects use, including my own.
Removed the optional trailing commas.
| usedevelop = true | ||
| commands = | ||
| {envpython} -R -Wonce {envbindir}/coverage run -a -m django test -v2 --settings=tests.settings {posargs} | ||
| {envpython} -R -Werror {envbindir}/coverage run -a -m django test -v2 --settings=tests.settings {posargs} |
There was a problem hiding this comment.
Using -Werror means that tests can catch incompatibility issues before releasing them onto users, at least in theory.
| @@ -1,6 +1,7 @@ | |||
| from datetime import date | |||
|
|
|||
| from django.db import models | |||
|
|
|||
There was a problem hiding this comment.
small adjustment from new isort, which is now correctly identifying picklefield as a first-party package.
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
These new versions of actions use new Node versions, so will prevent deprecation warnings in the run logs.
|
I unfortunately don't have administrative rights on the repository @adamchainz so I can't grant access for worklows to always run. I'll keep monitoring your pushes until they pass. |
|
@adamchainz thinks a looking good, I'll keep the PR unmerged for now as a reminder to merge + publish a new version by EOD. |
|
I just published 3.2.0. You should be all set. |
|
Thank you! I realized I missed |
This PR does a bunch of updates:
It also standardizes the testing with other projects a little bit, see comments.
All tests passed locally for me with
tox -p 5. The change to use-Werrormeans there are no warnings even.