Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of node_color_statistic as ndarray in plot_static_mapper_graph #576

Merged
merged 2 commits into from
Apr 11, 2021
Merged

Fix handling of node_color_statistic as ndarray in plot_static_mapper_graph #576

merged 2 commits into from
Apr 11, 2021

Conversation

ulupo
Copy link
Collaborator

@ulupo ulupo commented Apr 11, 2021 •
edited
Loading

Reference issues/PRs
Fixes #571.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description
Fixed this bug as suggested in #571. Also added a simple regression test.

Screenshots (if appropriate)

Any other comments?

Checklist

  • I have read the guidelines for contributing.
  • My code follows the code style of this project. I used flake8 to check my Python changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed. I used pytest to check this on Python tests.

@ulupo ulupo marked this pull request as ready for review April 11, 2021 12:41
@ulupo ulupo requested a review from wreise April 11, 2021 12:44
wreise
wreise approved these changes Apr 11, 2021
View reviewed changes
Copy link
Collaborator

@wreise wreise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ulupo ulupo merged commit 3227d42 into giotto-ai:master Apr 11, 2021
@ulupo ulupo deleted the fix_mapper_ndarray_color branch April 11, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wreise wreise wreise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node_color_statistic as ndarray for plot_static_mapper_graph
2 participants
@ulupo @wreise