Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Vue 2.6.X #111

Closed
wants to merge 1 commit into from
Closed

Upgrade to Vue 2.6.X #111

wants to merge 1 commit into from

Conversation

subdavis
Copy link
Contributor

@subdavis subdavis commented Apr 9, 2019

Running into vuejs/vue-cli#1584 but there isn't anything wrong I can tell.

Part of #103, will resolve #100


<template v-slot> can only appear at the root level inside the receiving the component

 FAIL  tests/unit/Register.spec.js
  ● Test suite failed to run


    [vue-jest] Error: Vue template compilation failed

      2 | import { mount } from '@vue/test-utils';
      3 | import RestClient from '@/rest';
    > 4 | import Register from '@/components/Authentication/Register.vue';
        | ^
      5 | import { flushPromises, girderVue } from './utils';
      6 | 
      7 | const localVue = girderVue();

      at error (node_modules/vue-jest/lib/throw-error.js:2:9)
      at compileTemplate (node_modules/vue-jest/lib/template-compiler.js:29:5)
      at Object.module.exports [as process] (node_modules/vue-jest/lib/process.js:66:29)
      at Object.<anonymous> (tests/unit/Register.spec.js:4:1)

 FAIL  tests/unit/Breadcrumb.spec.js
  ● Test suite failed to run

    SyntaxError: Unexpected character '#' (1:165)

      at Parser.pp$4.raise (node_modules/vue-template-es2015-compiler/buble.js:2757:13)
      at Parser.pp$8.getTokenFromCode (node_modules/vue-template-es2015-compiler/buble.js:4906:8)
      at Parser.pp$8.readToken (node_modules/vue-template-es2015-compiler/buble.js:4628:15)
      at Parser.readToken (node_modules/vue-template-es2015-compiler/buble.js:6029:22)
      at Parser.pp$8.nextToken (node_modules/vue-template-es2015-compiler/buble.js:4619:15)
      at Parser.pp$8.next (node_modules/vue-template-es2015-compiler/buble.js:4576:8)
      at Parser.pp.eat (node_modules/vue-template-es2015-compiler/buble.js:577:10)
      at Parser.pp.expect (node_modules/vue-template-es2015-compiler/buble.js:641:8)
      at Parser.pp$1.parseFunctionParams (node_modules/vue-template-es2015-compiler/buble.js:1230:8)
      at Parser.pp$1.parseFunction (node_modules/vue-template-es2015-compiler/buble.js:1218:8)

@zachmullen
Copy link
Member

The rewrite of the scoped slots documentation for 2.6 has made me understand them for the first time. This is a good change for sure.

@@ -121,7 +122,7 @@ export default {
get() {
if (this.browserLocation) {
return this.browserLocation;
} else if (this.girderRest.user) {
} if (this.girderRest.user) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@subdavis subdavis mentioned this pull request Apr 12, 2019
6 tasks
@subdavis subdavis mentioned this pull request Aug 29, 2019
@subdavis subdavis closed this Sep 4, 2019
@subdavis subdavis deleted the upgrade/2.6 branch September 4, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to use Vue's latest slot syntax
2 participants