Use the vue-async-computed library #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmullen
force-pushed
the
async-computed
branch
from
d1ef46c
to
76c53bb
Compare
|
This LGTM once we decide on #34. |
This instantiates a local Vue internally and then sets up the required plugins on it. This commit also stubs out CSS modules from testing (jest does not know how to load them). Refs #32
This means downstreams that are using Vue won't need to listen to events from girderRest injection at all, and instead can simply use computed properties if they depend on the user or token state. This changes App.vue to make use of this new feature.
zachmullen
force-pushed
the
async-computed
branch
from
76c53bb
to
ff0d169
Compare
|
Rebased |
jbeezley
approved these changes
Oct 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #34