Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Vuetify for layout rather than our own styling #43

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Use Vuetify for layout rather than our own styling #43

merged 1 commit into from
Oct 23, 2018

Conversation

zachmullen
Copy link
Member

No description provided.

jeffbaumes
jeffbaumes approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@jeffbaumes jeffbaumes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 What was the way in which you discovered this way of doing things with Vuetify? Changes like this improve the code considerably IMO.

@jeffbaumes jeffbaumes mentioned this pull request Oct 23, 2018
Closed
@zachmullen
Copy link
Member Author

I realized I had copypasted some stuff from an older project for this component, before I had learned about how to do layouts with Vuetify.

This was something I thought of in the shower, which happens more than I care to admit.

For those who are interested, the component-level docs for the layout related components are here, and here is a curated list of layout examples.

@zachmullen zachmullen merged commit b2ab669 into master Oct 23, 2018
@zachmullen zachmullen deleted the upload-component-layout branch October 23, 2018 12:25
@zachmullen zachmullen mentioned this pull request Oct 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffbaumes jeffbaumes jeffbaumes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachmullen @jeffbaumes