Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fine grain access (column filtering) #558

Closed
20 tasks done
laurent-thiebaud-gisaia opened this issue Nov 28, 2019 · 1 comment
Closed
20 tasks done

Fine grain access (column filtering) #558

laurent-thiebaud-gisaia opened this issue Nov 28, 2019 · 1 comment
Assignees
@laurent-thiebaud-gisaia
Labels
type:enhancement Feature that impacts end-user
Milestone
v12.7.4

Comments

@laurent-thiebaud-gisaia
Copy link
Contributor

laurent-thiebaud-gisaia commented Nov 28, 2019 •
edited by alainbodiguel
Loading

From a header parameter with a list of allowed (coma-separated) fields, filter the rest responses to use and return only these fields, if the header is provided. The collection's id, timestamp, geometry and centroid fields are always allowed.

The following endpoints are impacted in /explore :

  • /_aggregate
  • /_count
  • /_describe
  • /_list
  • /_geoaggregate
  • /_geosearch
  • /_range
  • /_search
  • /_tile

If a request contains, in its filter, a forbidden field, then a code 403 should be returned. The following parameters are impacted:

  • f
  • q; moreover if a 'q' parameter contains no target field but the column filter header is present, an exception should be thrown
  • sort
  • include
  • agggregations (main field, fetch_geometry, metrics and fetch_hits).

In search requests, only allowed fields should be returned.

In /explore/_describe & /explore/_list:

  • the returned properties should be filtered. If a node has no allowed property, then it is hidden.

In ogc-wfs project:

  • DescribeFeatureType: the returned properties should be filtered
  • GetFeature: the returned properties should be filtered. Return 403 if a filter field is forbidden
  • GetPropertyValue: return a 403 if a requested property isn't allowed. Return 403 if a filter field is forbidden

In opensearch project:

  • only return templates with available fields.

At the end,

  • update the documentation
laurent-thiebaud-gisaia added a commit that referenced this issue Nov 28, 2019
@laurent-thiebaud-gisaia
Fine Grain Access - Column filtering
f6d3ba7 
Apply column filtering to explore endpoints
(except "describe").
Update tests accordingly.
See #558
Closed
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 3, 2019
@laurent-thiebaud-gisaia
Fine Grain Access - Column filtering
c82f2f0 
Apply column filtering to explore endpoints
(except "describe") by returning a 403
if the user uses an unavailable column.
Update tests accordingly.
See #558
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 3, 2019
@laurent-thiebaud-gisaia
Fine Grain Access - Column filtering
7fac151 
Apply column filtering to explore endpoints
(except "describe") by returning a 403
if the user uses an unavailable column.
Update tests accordingly.
See #558
@alainbodiguel alainbodiguel mentioned this issue Dec 3, 2019
Closed
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 4, 2019
@laurent-thiebaud-gisaia
Fine Grain Access - Column filtering
606e71b 
Apply column filtering to explore endpoints
(except "describe") by returning a 403
if the user uses an unavailable column.
Update tests accordingly.
See #558

Filter the describe

Apply columns filtering
to /_describe & /_list.
With tests.
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 9, 2019
@laurent-thiebaud-gisaia
FGA - Apply column filtering to describe
2b4adaf 
Filter the fields in _describe and
_list.
Add integration tests.
Related to #558
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 10, 2019
@laurent-thiebaud-gisaia
Fine Grain Access - Column filtering
1a08634 
Apply column filtering to explore endpoints
by returning a 403 if the user uses an
unavailable column.
Update tests accordingly.
See #558
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 10, 2019
@laurent-thiebaud-gisaia
FGA - Documentation of column filtering
1825a3f 
Related to #558
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 16, 2019
@laurent-thiebaud-gisaia
FGA - Apply column filtering to describe
146bf17 
Filter the fields in _describe and
_list.
Add integration tests.
Related to #558
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 16, 2019
@laurent-thiebaud-gisaia
FGA - Apply column filtering to explore queries.
8b29f05 
Apply column filtering to explore endpoints
by returning a 403 if the user uses an
unavailable column.
Update tests accordingly.
See #558
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 17, 2019
@laurent-thiebaud-gisaia
Apply column filtering to OGC endpoints.
9fb233f 
Update tests accordingly.
Related tp See #558
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 17, 2019
@laurent-thiebaud-gisaia
FGA - Apply column filtering to Opensearch.
6642e4d 
With tests accordingly.
Closes #558.
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 18, 2019
@laurent-thiebaud-gisaia
FGA - Apply column filtering to explore queries.
4446734 
Apply column filtering to explore endpoints
by returning a 403 if the user uses an
unavailable column.
Update tests accordingly.
See #558
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 18, 2019
@laurent-thiebaud-gisaia
Apply column filtering to OGC endpoints.
64db341 
Update tests accordingly.
Related to #558
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 18, 2019
@laurent-thiebaud-gisaia
FGA - Apply column filtering to Opensearch.
7d1956c 
With tests accordingly.
Closes #558.
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 18, 2019
@laurent-thiebaud-gisaia
FGA - Documentation of column filtering
63d3a8e 
Related to #558
Merged
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 20, 2019
@laurent-thiebaud-gisaia
Apply column filtering to OGC endpoints.
96cbc09 
Update tests accordingly.
Related to #558
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 20, 2019
@laurent-thiebaud-gisaia
Apply column filtering to OGC endpoints.
eaab0b3 
Update tests accordingly.
Related to #558
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 20, 2019
@laurent-thiebaud-gisaia
FGA - Documentation of column filtering
eb44b05 
Related to #558
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 23, 2019
@laurent-thiebaud-gisaia
FGA - Apply column filtering to describe
84cdfe4 
Filter the fields in _describe and
_list.
Add integration tests.
Related to #558
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 23, 2019
@laurent-thiebaud-gisaia
FGA - Apply column filtering to describe
a546d5b 
Filter the fields in _describe and
_list.
Add integration tests.
Related to #558
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 23, 2019
@laurent-thiebaud-gisaia
FGA - Apply column filtering to explore queries.
343d69c 
Apply column filtering to explore endpoints
by returning a 403 if the user uses an
unavailable column.
Update tests accordingly.
See #558
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 24, 2019
@laurent-thiebaud-gisaia
FGA - Apply column filtering to describe
49f6c96 
Filter the fields in _describe and
_list.
Add integration tests.
Related to #558
laurent-thiebaud-gisaia added a commit that referenced this issue Dec 24, 2019
@laurent-thiebaud-gisaia
FGA - Apply column filtering to explore queries.
ba6e365 
Apply column filtering to explore endpoints
by returning a 403 if the user uses an
unavailable column.
Update tests accordingly.
See #558
@MohamedHamouGisaia MohamedHamouGisaia added this to the v12.7.4 milestone Jan 7, 2020
@laurent-thiebaud-gisaia
Copy link
Contributor Author

FGA should also be applied to v12

laurent-thiebaud-gisaia added a commit that referenced this issue Jan 13, 2020
@laurent-thiebaud-gisaia
FGA - Apply column filtering to describe
0d53afa 
Filter the fields in _describe and
_list.
Add integration tests.
Related to #558
laurent-thiebaud-gisaia added a commit that referenced this issue Jan 13, 2020
@laurent-thiebaud-gisaia
FGA - Apply column filtering to explore queries.
fc3a567 
Apply column filtering to explore endpoints
by returning a 403 if the user uses an
unavailable column.
Update tests accordingly.
See #558
laurent-thiebaud-gisaia added a commit that referenced this issue Jan 13, 2020
@laurent-thiebaud-gisaia
FGA - Apply column filtering to describe
07b5976 
Filter the fields in _describe and
_list.
Add integration tests.
Related to #558
laurent-thiebaud-gisaia added a commit that referenced this issue Jan 13, 2020
@laurent-thiebaud-gisaia
FGA - Apply column filtering to explore queries.
dffd4ec 
Apply column filtering to explore endpoints
by returning a 403 if the user uses an
unavailable column.
Update tests accordingly.
See #558
laurent-thiebaud-gisaia added a commit that referenced this issue Jan 31, 2020
@laurent-thiebaud-gisaia
FGA - Apply column filtering to describe
8b212e5 
Filter the fields in _describe and
_list.
Add integration tests.
Related to #558
laurent-thiebaud-gisaia added a commit that referenced this issue Jan 31, 2020
@laurent-thiebaud-gisaia
FGA - Apply column filtering to explore queries.
7a48e29 
Apply column filtering to explore endpoints
by returning a 403 if the user uses an
unavailable column.
Update tests accordingly.
See #558
laurent-thiebaud-gisaia added a commit that referenced this issue Feb 5, 2020
@laurent-thiebaud-gisaia
FGA - Apply column filtering to describe
d6c9d35 
Filter the fields in _describe and
_list.
Add integration tests.
Related to #558
laurent-thiebaud-gisaia added a commit that referenced this issue Feb 5, 2020
@laurent-thiebaud-gisaia
FGA - Apply column filtering to explore queries.
b5434f5 
Apply column filtering to explore endpoints
by returning a 403 if the user uses an
unavailable column.
Update tests accordingly.
See #558
@MohamedHamouGisaia MohamedHamouGisaia added the type:enhancement Feature that impacts end-user label Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurent-thiebaud-gisaia laurent-thiebaud-gisaia

Labels
type:enhancement Feature that impacts end-user
Projects
None yet
Milestone
v12.7.4
Development

No branches or pull requests
2 participants
@MohamedHamouGisaia @laurent-thiebaud-gisaia