New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAG selection rectangle leaves artifacts #204

Closed
sthalik opened this Issue Oct 4, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@sthalik
Contributor

sthalik commented Oct 4, 2013

DAG selection rectangle leaves artifacts

Please force-refresh on selection rectangle usage.

Here are my package versions:

* dependency graph for dev-vcs/git-cola-9999
`--  dev-vcs/git-cola-9999
  `--  dev-python/jsonpickle-0.4.0-r1  (dev-python/jsonpickle) amd64  [python_targets_python2_6(-)? python_targets_python2_7(-)? python_single_target_python2_6(+)? python_single_target_python2_7(+)?]
  `--  dev-python/pyinotify-0.9.4-r1  (dev-python/pyinotify) amd64  [python_targets_python2_6(-)? python_targets_python2_7(-)? python_single_target_python2_6(+)? python_single_target_python2_7(+)?]
  `--  dev-python/PyQt4-4.10.2  (dev-python/PyQt4) amd64  [python_targets_python2_6(-)? python_targets_python2_7(-)? python_single_target_python2_6(+)? python_single_target_python2_7(+)?]
  `--  dev-vcs/git-1.8.3.2  (dev-vcs/git) ~amd64
  `--  app-text/asciidoc-8.6.5  (app-text/asciidoc) amd64
  `--  dev-python/sphinx-1.1.3-r7  (dev-python/sphinx) amd64  [python_targets_python2_6(-)? python_targets_python2_7(-)? python_single_target_python2_6(+)? python_single_target_python2_7(+)?]
  `--  app-text/xmlto-0.0.24-r1  (app-text/xmlto) amd64
  `--  sys-devel/gettext-0.18.3.1  (sys-devel/gettext) ~amd64
  `--  dev-python/nose-1.3.0  (dev-python/nose) amd64  [python_targets_python2_6(-)? python_targets_python2_7(-)? python_single_target_python2_6(+)? python_single_target_python2_7(+)?]
  `--  dev-lang/python-2.6.8-r3  (dev-lang/python) amd64
  `--  dev-lang/python-2.7.5-r2  (dev-lang/python) amd64
  `--  dev-python/python-exec-0.3.1  (dev-python/python-exec) amd64  [python_targets_python2_6(-)? python_targets_python2_7(-)? python_single_target_python2_6(+)? python_single_target_python2_7(+)?]
[ dev-vcs/git-cola-9999 stats: packages (13), max depth (1) ]
@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Jun 10, 2014

Member

Small note: we can drop the asciidoc/xmlto dependencies these days. Please try the latest code and let me know if it mitigates the artifacts. I'll do some more testing on linux as well.

Member

davvid commented Jun 10, 2014

Small note: we can drop the asciidoc/xmlto dependencies these days. Please try the latest code and let me know if it mitigates the artifacts. I'll do some more testing on linux as well.

@davvid davvid closed this in 059933e Jun 10, 2014

davvid added a commit to davvid/git-cola that referenced this issue Jun 10, 2014

widgets.dag: repaint the viewport when dragging the mouse
This prevents selection artifacts when selecting near labels.

Related-to: #204
Signed-off-by: David Aguilar <davvid@gmail.com>

davvid added a commit to davvid/git-cola that referenced this issue Jun 10, 2014

widgets.dag: repaint the viewport when dragging and releasing
This prevents selection artifacts when selecting near labels.

Related-to: #204
Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid

This comment has been minimized.

Show comment
Hide comment
@davvid

davvid Jun 10, 2014

Member

I tested this a bit more and adding the viewport().repaint() calls definitely helped. Thanks for the heads-up.

Member

davvid commented Jun 10, 2014

I tested this a bit more and adding the viewport().repaint() calls definitely helped. Thanks for the heads-up.

@sthalik

This comment has been minimized.

Show comment
Hide comment
@sthalik

sthalik Jun 11, 2014

Contributor

Hope doesn't slow down the hot path.

Pleasure to work with you.

Note that was present on only some theme engines, e.g. QT/KDE oxygen.

Contributor

sthalik commented Jun 11, 2014

Hope doesn't slow down the hot path.

Pleasure to work with you.

Note that was present on only some theme engines, e.g. QT/KDE oxygen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment