New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alt- keyboard shortcuts for menu navigation #759

Closed
Vdragon opened this Issue Dec 13, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@Vdragon
Contributor

Vdragon commented Dec 13, 2017

_532

Currently Git Cola doesn't support menu navigation using the conventional alt- keyboard shortcuts, this creates difficulty for people don't have a pointer device or chooses to don't use one for some reason.

@davvid

This comment has been minimized.

Member

davvid commented Mar 4, 2018

We should fix this, but not sure if it's something Qt is already doing automatically for us.

On debian, I was just able to type "Alt + Down" and it activated the menu. I switched over to gnome (+lots of extensions and tweaks) from xfce4 and not sure if that's a gnome hotkey, but it activated the file menu, which then allowed me to navigate to the edit menu using the left and right arrow keys. So maybe this already works?

MacOS might have its own hotkey to activate the menu.

@Vdragon

This comment has been minimized.

Contributor

Vdragon commented Mar 4, 2018

Comparison: The letter combination that should be used to activate the sub-menu is underlined (at least when Alt is hold)

VLC

Currently Git Cola assigned some shortcuts that may conflict with the menu, like Edit (Alt+E) which is assigned to "File > Export Patches..."

@Vdragon Vdragon added the usability label Mar 4, 2018

davvid added a commit to davvid/git-cola that referenced this issue Mar 5, 2018

hotkeys: change "Export Patches" hotkey to Alt+Shift+E
open up "Alt+E" so that it can be used by the edit menu.

Related-to: git-cola#759
Suggested-by: V字龍 <Vdragon.Taiwan@gmail.com>
Signed-off-by: David Aguilar <davvid@gmail.com>

davvid added a commit to davvid/git-cola that referenced this issue Mar 5, 2018

main: enable native menu bars
Related-to: git-cola#759
Signed-off-by: David Aguilar <davvid@gmail.com>

davvid added a commit to davvid/git-cola that referenced this issue Mar 5, 2018

Merge branch 'hotkeys'
Add support for Alt-key menu navigation.

* hotkeys:
  main: support Alt-key navigation for the File and Edit menus
  main: enable native menu bars
  hotkeys: change "Export Patches" hotkey to Alt+Shift+E

Closes git-cola#759
Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid closed this in 561f6db Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment