Fixed build-git-cola.sh. #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$install_dir does not exist. Instead, changed it to $COLA_PREFIX. $COMPILE_TOP does not eixst. Instead, changed it to $compile_top. The command to make git-cola was incorrect as it uses the currently installed Python. Instead, it should be using the Python that was just built and installed. Modified the make command to include overriding the PYTHON value. After fixing the make command, the extra script that adds environment variables to run git-cola are no longer needed. Removed the notes about the script and added notes to simply use git-cola from the install.
davvid
added a commit
that referenced
this pull request
Feb 25, 2014
Fixed build-git-cola.sh. Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$install_dir does not exist. Instead, changed it to $COLA_PREFIX.
$COMPILE_TOP does not eixst. Instead, changed it to $compile_top.
The command to make git-cola was incorrect as it uses the currently
installed Python. Instead, it should be using the Python that was just
built and installed. Modified the make command to include overriding the
PYTHON value.
After fixing the make command, the extra script that adds environment
variables to run git-cola are no longer needed. Removed the notes about
the script and added notes to simply use git-cola from the install.