New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build-git-cola.sh. #235

Merged
merged 1 commit into from Feb 25, 2014

Conversation

Projects
None yet
2 participants
@wmwong

wmwong commented Feb 25, 2014

$install_dir does not exist. Instead, changed it to $COLA_PREFIX.

$COMPILE_TOP does not eixst. Instead, changed it to $compile_top.

The command to make git-cola was incorrect as it uses the currently
installed Python. Instead, it should be using the Python that was just
built and installed. Modified the make command to include overriding the
PYTHON value.

After fixing the make command, the extra script that adds environment
variables to run git-cola are no longer needed. Removed the notes about
the script and added notes to simply use git-cola from the install.

Wesley Wong
Fixed build-git-cola.sh.
$install_dir does not exist. Instead, changed it to $COLA_PREFIX.

$COMPILE_TOP does not eixst. Instead, changed it to $compile_top.

The command to make git-cola was incorrect as it uses the currently
installed Python. Instead, it should be using the Python that was just
built and installed. Modified the make command to include overriding the
PYTHON value.

After fixing the make command, the extra script that adds environment
variables to run git-cola are no longer needed. Removed the notes about
the script and added notes to simply use git-cola from the install.

davvid added a commit that referenced this pull request Feb 25, 2014

Merge pull request #235 from wmwong/master
Fixed build-git-cola.sh.

Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid merged commit da68939 into git-cola:master Feb 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment