-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotkeys: change copy-sha1 hotkey #705
Conversation
Change copy-sha1 hotkey to ctrl + alt + c. Original hotkey blocked copying selected text from dag window using ctrl + c Reported-by: @Vdragon git-cola#694 Signed-off-by: Szymon Judasz szymon.judasz@student.uj.edu.pl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built and tested, LGFM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good so far, but the docs need to be updated too.
Please update the stuff in share/doc/git-cola/*
to reflect the new hotkey. There should be .rst
and .html
files (for the hotkeys window) that should be updated by this PR.
Add information in english and german. zh_CN and zh_TW got english version Signed-off-by: Szymon Judasz szymon.judasz@student.uj.edu.pl
EDIT: ok, git-dag.rst is the file that should be changed. |
Signed-off-by: Szymon Judasz szymon.judasz@student.uj.edu.pl
@davvid added text in .html and .rst files. Can you review again? |
Change the "Copy SHA-1" hotkey to Alt + Ctrl + C. * judaszszymon/copysha: doc/git-dag.rst add formating to keyboard shortcut doc/git-dag.rst add section about keyboard shortcuts doc/hotkeys: add information about copy sha1 hotkey Add information in english and german. zh_CN and zh_TW got english version hotkeys: change copy-sha1 hotkey Change copy-sha1 hotkey to ctrl + alt + c. Original hotkey blocked copying selected text from dag window using ctrl + c Signed-off-by: David Aguilar <davvid@gmail.com>
Change copy-sha1 hotkey to ctrl + alt + c.
Original hotkey blocked copying selected text from dag window using ctrl + c
Reported-by: @Vdragon #694
Signed-off-by: Szymon Judasz szymon.judasz@student.uj.edu.pl