New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotkeys: change copy-sha1 hotkey #705

Merged
merged 4 commits into from Jul 6, 2017

Conversation

Projects
None yet
3 participants
@judaszszymon
Contributor

judaszszymon commented Jun 15, 2017

Change copy-sha1 hotkey to ctrl + alt + c.
Original hotkey blocked copying selected text from dag window using ctrl + c

Reported-by: @Vdragon #694
Signed-off-by: Szymon Judasz szymon.judasz@student.uj.edu.pl

hotkeys: change copy-sha1 hotkey
Change copy-sha1 hotkey to ctrl + alt + c.
Original hotkey blocked copying selected text from dag window using ctrl + c

Reported-by: @Vdragon #694
Signed-off-by: Szymon Judasz szymon.judasz@student.uj.edu.pl
@Vdragon

Built and tested, LGFM

@davvid

Thanks, looks good so far, but the docs need to be updated too.

Please update the stuff in share/doc/git-cola/* to reflect the new hotkey. There should be .rst and .html files (for the hotkeys window) that should be updated by this PR.

doc/hotkeys: add information about copy sha1 hotkey
Add information in english and german. zh_CN and zh_TW got english version

Signed-off-by: Szymon Judasz szymon.judasz@student.uj.edu.pl
@judaszszymon

This comment has been minimized.

Show comment
Hide comment
@judaszszymon

judaszszymon Jun 28, 2017

Contributor

Cannot find .rst file that should be edited.

EDIT: ok, git-dag.rst is the file that should be changed.

Contributor

judaszszymon commented Jun 28, 2017

Cannot find .rst file that should be edited.

EDIT: ok, git-dag.rst is the file that should be changed.

@judaszszymon

This comment has been minimized.

Show comment
Hide comment
@judaszszymon

judaszszymon Jun 29, 2017

Contributor

@davvid added text in .html and .rst files. Can you review again?

Contributor

judaszszymon commented Jun 29, 2017

@davvid added text in .html and .rst files. Can you review again?

davvid added a commit to davvid/git-cola that referenced this pull request Jul 6, 2017

Merge pull request git-cola#705 from judaszszymon/copysha
Change the "Copy SHA-1" hotkey to Alt + Ctrl + C.

* judaszszymon/copysha:
  doc/git-dag.rst add formating to keyboard shortcut
  doc/git-dag.rst add section about keyboard shortcuts
  doc/hotkeys: add information about copy sha1 hotkey Add
      information in english and german. zh_CN and zh_TW got
      english version
  hotkeys: change copy-sha1 hotkey Change copy-sha1 hotkey to
      ctrl + alt + c. Original hotkey blocked copying selected
      text from dag window using ctrl + c

Signed-off-by: David Aguilar <davvid@gmail.com>

@davvid davvid merged commit d7d6ede into git-cola:master Jul 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment