Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting of 2.17.2 to Git for Windows #1873

Closed
StanleyGoldman opened this issue Oct 10, 2018 · 4 comments
Closed

Porting of 2.17.2 to Git for Windows #1873

StanleyGoldman opened this issue Oct 10, 2018 · 4 comments

Comments

@StanleyGoldman
Copy link

👋 Hello.

I work on GitHub for Unity which currently deploys and utilizes "2.17.1.windows.1" for users. I wanted to get the recent submodule vulnerability into our project and I was relieved to hear that the fix was backported in 2.17.2, but I quickly realized that did not mean Git for Windows had a 2.17.2.

I wanted to know if you had plans to or if I could compel you also release a 2.17.2 of Git for Windows?

@StanleyGoldman
Copy link
Author

Paying more attention the actual vulnerability, I'm now reading this..

P.S. Folks at Microsoft tried to follow the known exploit recipe on
Git for Windows (but not Cygwin or other Git implementations on
Windows) and found that the recipe (or its variants they can think
of) would not make their system vulnerable.  This is due to the fact
that the type of submodule path require by the known exploit recipe
cannot be created on Windows. Nonetheless, it is possible we have
missed some exploitation path and users are encouraged to upgrade.
Nonetheless, it is possible we have missed some exploitation path and
users are encouraged to upgrade.

https://public-inbox.org/git/xmqqy3bcuy3l.fsf@gitster-ct.c.googlers.com/T/#u

@StanleyGoldman
Copy link
Author

The more I learn about the vulnerability the more I learn that it may not even be reproducible on Windows. So this may all be a non-starter. Thanks.

@dscho
Copy link
Member

dscho commented Oct 12, 2018

And besides, v2.19.1 is already out. We are too short-handed to do maintenance releases on old Git for WIndows release trains. As soon as a new major version is released by core Git, we switch to that new version in Git for Windows.

@StanleyGoldman
Copy link
Author

I understand. Thanks for the reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants