Weekly Digest (7 October, 2018 - 14 October, 2018)

[weekly-digest]

Here's the Weekly Digest for git-for-windows/git:

ISSUES

This week, 30 issues were created. Of these, 6 issues have been closed and 24 issues are still open.

OPEN ISSUES

💚 #1881 Version 2.19.1 is being flagged as malicious by Hybrid Analysis, by KevinNapper
💚 #1880 open /dev/null or dup failed, by javahook
💚 #1879 Windows 10 cannot close existing git (sh.exe) when running setup, by kvernon
💚 #1878 Git Bash Sets USERNAME Instead of USER, by jcburley
💚 #1877 Git Gui open file error handling, by ssrinath
💚 #1876 Built-in rebase fails with 'Unexpected stash response' (MVCE included), by rcdailey
💚 #1875 When making a merge commit, git hangs waiting for the commit message even though I saved and closed the editor (VS Code), by Admiralfeb
💚 #1872 Feature request: clarify default editor option, by zwilliams
💚 #1871 Re-implement git add -i as built-in, by dscho
💚 #1869 gpg unable to generate absolute path for windows drives, by cmllamas
💚 #1867 Add rfc to remove an TODO: that seems to be referencing the wrong struct field commit.c:360, by skinnyal
💚 #1866 Git 2.19.1 crashes while git gc in Windows, by guoxiao
💚 #1865 Cannot start git-bash maximized, by Bilge
💚 #1863 pass extended startup info directly, by drizzd
💚 #1859 Fix t0001 when the current working directory differs in case from the canonical form, by dscho
💚 #1858 Git Bash for Windows expands glob patterns even when quoted, by bberstel
💚 #1851 --jobs has no effect, by Kojoley
💚 #1838 symbolic links - core.symlinks=true does not work - you might want to revisit problem --, by aabatpurdue
💚 #1820 New experimental stash builtin fails with changes in submodule [recipe included], by t-b
💚 #1811 Index File integrity fragile. Easily corrupted after unexpected shutdown/kernel panic. Lack of documentation., by Zexaron
💚 #1715 git status porcelain output should include remote details, by shiftkey
💚 #1681 completion: add ref completion to worktree add, by iamdjones
💚 #1604 Improve handling of commands in Git.pm on native Windows, by ColMelvin
💚 #1368 WIP: Introduce a compile-time flag to diagnose file locking issues, by dscho

CLOSED ISSUES

❤️ #1874 git credential-manager is causing huge delays, by patryksuchowierski
❤️ #1873 Porting of 2.17.2 to Git for Windows, by StanleyGoldman
❤️ #1870 Git installation maybe interfering with plink & gitlab, by c33s
❤️ #1868 git pull fatal: NullReferenceException encountered. On an local instance of Bitbucket, by dougheeren
❤️ #1845 git: 'credential-windcred' is not a git command. See 'git --help'., by Szauka
❤️ #1816 Don't use uninitialized variable, by csware

LIKED ISSUE

The issue most liked this week has been:
👍 #1868 git pull fatal: NullReferenceException encountered. On an local instance of Bitbucket, by dougheeren
It received 👍 x7, 😄 x0, 🎉 x0 and ❤️ x0.

NOISY ISSUE

The issue most discussed this week has been:
🔈 #1604 Improve handling of commands in Git.pm on native Windows, by ColMelvin
It received 34 comments.

PULL REQUESTS

This week, 1 pull request has been proposed, which is still open.

OPEN PRs

💚 #1867 Add rfc to remove an TODO: that seems to be referencing the wrong struct field commit.c:360, by skinnyal

CONTRIBUTORS

This week, 28 users have contributed to this repository.
They are KevinNapper, javahook, kvernon, jcburley, ssrinath, rcdailey, Admiralfeb, patryksuchowierski, StanleyGoldman, zwilliams, dscho, c33s, cmllamas, dougheeren, skinnyal, guoxiao, Bilge, drizzd, bberstel, Kojoley, Szauka, aabatpurdue, t-b, csware, Zexaron, shiftkey, iamdjones, and ColMelvin.

STARGAZERS

This week, no user has starred this repository.

COMMITS

This week, there have been 30 commits in the repository.
These are:
🛠️ [Merge 'builtin-stash-rebase-v3'

To avoid having to play tricks as in earlier rounds, we bit the sour
apple and rebased the builtin-stash-rebase-v3 branch thicket onto the
commit starting Git for Windows' merging-rebase.

(The merging-rebase pulls in the previous branch thicket via a "fake
merge", i.e. a merge commit that does not actually apply any changes
from the merged commit history. This has the unfortunate side effect of
confusing merge into thinking that any branch that was merged into an
earlier round does not need to be merged again.)

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](6cbf663) by jamill
🛠️ [Merge 'readme' into HEAD

Add a README.md for GitHub goodness.

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](18d4918) by dscho
🛠️ [Merge branch 'fix-terminal-prompt'

This fixes the issue identified in

https://github.com/git-for-windows/git/issues/1498

where Git would not fall back to reading credentials from a Win32
Console when the credentials could not be read from the terminal via the
Bash hack (that is necessary to support running in a MinTTY).

Tested in a Powershell window.

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](4a8c9ef) by dscho
🛠️ [Merge branch 'busybox-w32'

This topic branch brings slightly experimental changes supporting Git
for Windows to use BusyBox-w32 to execute its shell scripts as well as
its test suite.

The test suite can be run by installing the test artifacts into a MinGit
that has busybox.exe (and using Git for Windows' SDK's Perl for now, as
the test suite requires Perl even when NO_PERL is set, go figure) by
using the install-mingit-test-artifacts Makefile target with the
DESTDIR variable pointing to the top-level directory of the MinGit
installation.

To facilitate running the test suite (without having make available,
as make.exe is not part of MinGit), this branch brings an experimental
patch to the test-run-command helper to run Git's test suite. It is
still very experimental, though: in this developer's tests it seemed
that the poll() emulation required for run_parallel_processes() to
work sometimes hiccups on Windows, causing infinite "hangs". It is also
possible that BusyBox itself has problems writing to the pipes opened by
test-run-command (and merging this branch will help investigate
further). Caveat emptor.

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](1ee0267) by dscho
🛠️ [gitattributes: mark .png files as binary

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](d43008d) by dscho
🛠️ [Merge branch 'inherit-only-stdhandles'

When spawning child processes, we do want them to inherit the standard
handles so that we can talk to them. We do not want them to inherit
any other handle, as that would hold a lock to the respective files
(preventing them from being renamed, modified or deleted), and the child
process would not know how to access that handle anyway.

Happily, there is an API to make that happen. It is supported in Windows
Vista and later, which is exactly what we promise to support in Git for
Windows for the time being.

This also means that we lift, at long last, the target Windows version
from Windows XP to Windows Vista.

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](71beb92) by dscho
🛠️ [Merge pull request #1170 from dscho/mingw-kill-process

Handle Ctrl+C in Git Bash nicely

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](0db9119) by dscho
🛠️ [Merge branch 'fsync-object-files-always'

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](dd4bcb8) by dscho
🛠️ [Merge branch 'fix-vcxproj-generation'

We ran out of GUIDs in the script generating Visual Studio project
files. This topic branch fixes that issue once and for all, by
generating the GUIDs.

For extra goodness, we now generate GUIDs that are not random, but are
generated from the SHA-256 checksums of the target file of the project.
That way, the project<->GUID mapping is stable.

This fixes #1507

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](b0b142b) by dscho
🛠️ [Merge pull request #1304 from jeffhostetler/vs2017_vcpkg

VS2017 vcpkg support.](289d256) by dscho
🛠️ [Merge pull request #1302 from jeffhostetler/vs2017_vcxproj

VS2017 vcxproj](0fa8a74) by dscho
🛠️ [Merge branch 'visual-studio'

This topic branch teaches the project generator to generate a Visual
Studio solution, ready to be opened in Visual Studio 2010 or later.

The idea, of course, is to let some automatic build job generate and
commit the project files with

make MSVC=1 vcxproj

and then (force-)push to a special-purpose branch.

The major part of this branch thicket concerns itself not only with
generating the Visual Studio project files, but making sure that the
user can then run the test suite from a regular Git Bash (i.e. not
requiring a Git for Windows SDK), e.g. by running

cd t
prove --timer --jobs 15 ./t[0-9]*.sh

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](2a8356c) by dscho
🛠️ [Merge pull request #773 from jeffhostetler/vs2015

Build with VS2015](2ddda64) by dscho
🛠️ [Merge pull request #1354 from dscho/phase-out-show-ignored-directory-gracefully

Phase out --show-ignored-directory gracefully](681e1d5) by dscho
🛠️ [Merge branch 'status-no-lock-index'

This branch allows third-party tools to call git status --no-lock-index to avoid lock contention with the interactive Git usage
of the actual human user.

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](3fc0ecc) by dscho
🛠️ [Merge 'docker-volumes-are-no-symlinks'

This was pull request #1645 from ZCube/master

Support windows container.

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](fb3fca1) by dscho
🛠️ [Merge pull request #1827 from benpeart/fscache_refresh_index

Enable the filesystem cache (fscache) in refresh_index().](7fee55e) by dscho
🛠️ [Merge pull request #1468 from atetubou/fscache_checkout_flush

checkout.c: enable fscache for checkout again

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](aa0df58) by dscho
🛠️ [Merge pull request #1426 from atetubou/fetch_pack

fetch-pack.c: enable fscache for stats under .git/objects](a628956) by dscho
🛠️ [Merge pull request #1344 from jeffhostetler/perf_add_excludes_with_fscache

dir.c: make add_excludes aware of fscache during status](ccec401) by dscho
🛠️ [Merge pull request #971 from jeffhostetler/jeffhostetler/add_preload_fscache

add: use preload-index and fscache for performance](79f371f) by dscho
🛠️ [Merge branch 'core-longpaths-everywhere'

Git for Windows supports the core.longPaths config setting to allow
writing/reading long paths via the \?\ trick for a long time now.

However, for that support to work, it is absolutely necessary that
git_default_config() is given a chance to parse the config. Otherwise
Git will be non the wiser.

So let's make sure that as many commands that previously failed to
parse the core.* settings now do that, implicitly enabling long path
support in a lot more places.

Note: this is not a perfect solution, and it cannot be, as there is
a chicken-and-egg problem in reading the config itself...

This fixes #1218

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](877fd24) by dscho
🛠️ [Merge pull request #994 from jeffhostetler/jeffhostetler/fscache_nfd

fscache: add not-found directory cache to fscache](e7f0ae2) by dscho
🛠️ [Merge branch 'spawn-with-spaces'

This change lets us spawn .bat scripts whose paths contain spaces.

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](21f5232) by dscho
🛠️ [Merge branch 'clean-long-paths'

This addresses #521

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](e63e262) by dscho
🛠️ [Merge pull request #305 from dscho/msysgit_issues_182

Allow add -p and add -i with a large number of files](06fa4a3) by dscho
🛠️ [Merge branch 'program-data-config'

This branch introduces support for reading the "Windows-wide" Git
configuration from %PROGRAMDATA%\Git\config. As these settings are
intended to be shared between all Git-related software, that config
file takes an even lower precedence than $(prefix)/etc/gitconfig.

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](b2a5e53) by dscho
🛠️ [Merge pull request #443 from kblees/kb/nanosecond-file-times-v2.5.3

nanosecond file times for v2.5.3](0d85de6) by dscho
🛠️ [Merge pull request #156 from kblees/kb/symlinks

Symlink support](049f780) by dscho
🛠️ [Merge 'msys2' into HEAD

This is really a bag of patches in different stages of readiness. We
will need to revisit all of them at some stage, but maybe we can first
pay down some technical debt by contributing the topics in
ready-for-upstream to the Git mailing list.

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de](79bc350) by dscho

RELEASES

This week, no releases were published.

That's all for this week, please watch 👀 and star ⭐ git-for-windows/git to receive next weekly updates. 😃