Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git svn broken in git version 2.33.0.windows.2 #3392

Closed
1 task done
fedorbirjukov opened this issue Aug 25, 2021 · 22 comments · Fixed by git-for-windows/MSYS2-packages#47
Closed
1 task done

git svn broken in git version 2.33.0.windows.2 #3392

fedorbirjukov opened this issue Aug 25, 2021 · 22 comments · Fixed by git-for-windows/MSYS2-packages#47

Comments

@fedorbirjukov
Copy link

fedorbirjukov commented Aug 25, 2021

  • I was not able to find an open or closed issue matching what I'm seeing

Setup

  • Which version of Git for Windows are you using? Is it 32-bit or 64-bit?
    git version 2.33.0.windows.2, 64-bit

    $ git --version --build-options
    
    git version 2.33.0.windows.2
    cpu: x86_64
    built from commit: 8735530946cced809cc6cc4c2ca3b078cdb3dfc8
    sizeof-long: 4
    sizeof-size_t: 8
    shell-path: /bin/sh
    feature: fsmonitor--daemon
    
  • Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

    $ cmd.exe /c ver
    
    Microsoft Windows [Version 10.0.18363.1679]
    
  • What options did you set as part of the installation? Or did you choose the
    defaults?

    # One of the following:
    > type "C:\Program Files\Git\etc\install-options.txt"
    > type "C:\Program Files (x86)\Git\etc\install-options.txt"
    > type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
    $ cat /etc/install-options.txt
    
    Editor Option: VIM
    Custom Editor Path:
    Default Branch Option: main
    Path Option: Cmd
    SSH Option: OpenSSH
    Tortoise Option: false
    CURL Option: WinSSL
    CRLF Option: CRLFAlways
    Bash Terminal Option: MinTTY
    Git Pull Behavior Option: FFOnly
    Use Credential Manager: Core
    Performance Tweaks FSCache: Enabled
    Enable Symlinks: Disabled
    Enable Pseudo Console Support: Disabled
    Enable FSMonitor: Enabled
    
  • Any other interesting things about your environment that might be related
    to the issue you're seeing?

    No

Details

  • Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

    PowerShell

  • What commands did you run to trigger this issue? If you can provide a
    Minimal, Complete, and Verifiable example
    this will help us understand the issue.

    I was running commit-diff, but the issue is reproducible with a simple clone:

    git svn clone https://github.com/git-for-windows/build-extra/trunk
    
  • What did you expect to occur after running these commands?

    I expected git svn to do the clone. Usually it produces output like this:

    Initialized empty Git repository in ...
    ... omitted lines ...
    Checked out HEAD:
      https://github.com/git-for-windows/build-extra/trunk r123
    
  • What actually happened instead?

    Git svn produced the following errors:

    Can't load '/usr/lib/perl5/vendor_perl/auto/SVN/_Core/_Core.dll' for module SVN::_Core: No such file or directory at /usr/lib/perl5/core_perl/DynaLoader.pm line 193.
     at /usr/lib/perl5/vendor_perl/SVN/Base.pm line 59.
    BEGIN failed--compilation aborted at /usr/lib/perl5/vendor_perl/SVN/Core.pm line 5.
    Compilation failed in require at C:/Program Files/Git/mingw64/share/perl5/Git/SVN/Utils.pm line 6.
    BEGIN failed--compilation aborted at C:/Program Files/Git/mingw64/share/perl5/Git/SVN/Utils.pm line 6.
    Compilation failed in require at C:/Program Files/Git/mingw64/share/perl5/Git/SVN.pm line 32.
    BEGIN failed--compilation aborted at C:/Program Files/Git/mingw64/share/perl5/Git/SVN.pm line 32.
    Compilation failed in require at C:/Program Files/Git/mingw64/libexec/git-core\git-svn line 64.
    BEGIN failed--compilation aborted at C:/Program Files/Git/mingw64/libexec/git-core\git-svn line 64.
    
  • If the problem was occurring with a specific repository, can you provide the
    URL to that repository to help us with testing?

    You can use any repository. E.g.: https://github.com/git-for-windows/build-extra

  • What's the latest version of Git where you do not experience this issue?

    Git svn commands seem to work fine in these versions:

    • git version 2.32.0.windows.2
    • git version 2.31.1.windows.1
    • git version 2.29.1.windows.1
    • git version 2.28.0.windows.1
    • git version 2.24.1.windows.2
@bmueller84
Copy link

I'm experiencing the same issue. Only thing I have to add is that it still worked for me with 2.33.0.windows.1

@dscho
Copy link
Member

dscho commented Aug 25, 2021

I can reproduce, but I am a bit stretched. Could I ask you to help identify the root cause e.g. by testing the Aug 23 snapshot (i.e. the snapshot between v2.33.0 and v2.33.0(2))?

And maybe even try to identify the exact file(s) that need to be replaced in v2.33.0(2) to fix it (I would do that by extracting two portable Gits, identifying which files are different/missing, and copying a couple of them over until the symptoms go away).

Thank you so much in advance!

@bmueller84
Copy link

Was able to do a quick test; the Aug 23 is already bad.

@dscho
Copy link
Member

dscho commented Aug 25, 2021

Was able to do a quick test; the Aug 23 is already bad.

Okay, then I suspect that the problem was caused by upgrading cURL (it lost the metalink dependency, which depended on libexpat, and both were removed as a consequence).

dscho added a commit to dscho/git-sdk-64 that referenced this issue Aug 25, 2021
There have been two major breakages recently, might just as well try to
prevent them from happening again:

- git-for-windows/git#3348 (v2.33.0-rc0)
- git-for-windows/git#3392 (v2.33.0(2))

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member

dscho commented Aug 25, 2021

TBH I had hoped for a bit more assistance here. Now I have to somehow squeeze out the time to investigate myself 😞

@bmueller84
Copy link

bmueller84 commented Aug 25, 2021

TBH I had hoped for a bit more assistance here. Now I have to somehow squeeze out the time to investigate myself 😞

Fully understand, but that's all I could squeeze in today (during my day job).

@dscho
Copy link
Member

dscho commented Aug 25, 2021

FWIW once we found the culprit and fixed it, I am thinking about releasing Git for Windows v2.33.0(3). It would also include OpenSSL v1.1.1l (which fixes a high severity CVE). But maybe I should not rush things so much, git svn is not all that widely in use anymore, after all.

@dscho
Copy link
Member

dscho commented Aug 25, 2021

It would seem that copying usr/bin/msys-expat-1.dll from a good version lets git svn -h work again.

@bmueller84
Copy link

Many thanks for the quick fix. Please let me know if you want me to verify the fix (and if yes, where I can find the corresponding snapshot).
Regarding your other question: I see no need for rushing anything. Knowing git svn will be fixed in the next version (whenever it will arrive) is sufficient for me.

@dscho
Copy link
Member

dscho commented Aug 26, 2021

I see no need for rushing anything.

Thank you for that datapoint.

Please let me know if you want me to verify the fix

Yes, once there is a new snapshot, I would love to ask you to verify that git svn works again.

@dscho
Copy link
Member

dscho commented Aug 26, 2021

Please let me know if you want me to verify the fix

Yes, once there is a new snapshot, I would love to ask you to verify that git svn works again.

Here is a build: https://github.com/git-for-windows/git/actions/runs/1171601455

@R4to0
Copy link

R4to0 commented Aug 26, 2021

Here is a build: https://github.com/git-for-windows/git/actions/runs/1171601455

Had the same issue as OP with the stable build and tested myself that one, now it works as expected. Thank you!

@bmueller84
Copy link

Here is a build: https://github.com/git-for-windows/git/actions/runs/1171601455

Had the same issue as OP with the stable build and tested myself that one, now it works as expected. Thank you!

Same here; thanks!

@dscho
Copy link
Member

dscho commented Aug 31, 2021

For the record, there is now a snapshot with the fix. These snapshots are precisely like the official Git for Windows versions, with the exception of the funny version number ;-)

@fedorbirjukov
Copy link
Author

fedorbirjukov commented Sep 1, 2021 via email

@rimrul
Copy link
Member

rimrul commented Sep 1, 2021

It's already closed. No further action needed.

@JanVelas
Copy link

Thank you

@r-a-y
Copy link

r-a-y commented Sep 29, 2021

It would seem that copying usr/bin/msys-expat-1.dll from a good version lets git svn -h work again.

Thanks dscho! This worked for me.

For those that are using 64-bit and do not want to download the entire Git snapshot, here's the msys-expat-1.dll file from snapshot 2aa9e28. Unzip to /usr/bin/.

msys-expat-1.zip

This will fix SVN on Git 2.33.0.windows.2 until the next release is ready.

dscho added a commit to git-for-windows/build-extra that referenced this issue Oct 2, 2021
The `git svn` command, which was broken in Git for Windows v2.33.0(2),
[has been fixed](git-for-windows/git#3392).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member

dscho commented Oct 4, 2021

It would seem that copying usr/bin/msys-expat-1.dll from a good version lets git svn -h work again.

Thanks dscho! This worked for me.

For those that are using 64-bit and do not want to download the entire Git snapshot, here's the msys-expat-1.dll file from snapshot 2aa9e28. Unzip to /usr/bin/.

msys-expat-1.zip

This will fix SVN on Git 2.33.0.windows.2 until the next release is ready.

An even better workaround is to upgrade to the latest snapshot (as I had already mentioned).

@rimrul rimrul unpinned this issue Oct 8, 2021
@rimrul rimrul pinned this issue Oct 8, 2021
@dscho
Copy link
Member

dscho commented Oct 14, 2021

Everybody coming to this ticket: please update to Git for Windows v2.33.1.

@dscho dscho unpinned this issue Oct 31, 2021
@ahsan-kaukab
Copy link

I have the same issue on widowns 10 with old git version :
D:\Project_dir>git svn clone https://svn.dpdev.com/svn/Retron_4/trunk/Software/RF2_PCB_B/RF2B-new
Can't load '/usr/lib/perl5/vendor_perl/auto/SVN/_Core/_Core.dll' for module SVN::_Core: No such file or directory at /usr/lib/perl5/core_perl/DynaLoader.pm line 193.
at /usr/lib/perl5/vendor_perl/SVN/Base.pm line 59.
BEGIN failed--compilation aborted at /usr/lib/perl5/vendor_perl/SVN/Core.pm line 5.
Compilation failed in require at C:/Program Files/Git/mingw64/share/perl5/Git/SVN/Utils.pm line 6.
BEGIN failed--compilation aborted at C:/Program Files/Git/mingw64/share/perl5/Git/SVN/Utils.pm line 6.
Compilation failed in require at C:/Program Files/Git/mingw64/share/perl5/Git/SVN.pm line 32.
BEGIN failed--compilation aborted at C:/Program Files/Git/mingw64/share/perl5/Git/SVN.pm line 32.
Compilation failed in require at C:/Program Files/Git/mingw64/libexec/git-core\git-svn line 64.
BEGIN failed--compilation aborted at C:/Program Files/Git/mingw64/libexec/git-core\git-svn line 64.

Issue is solved by using updating the git on windows
Actually running following command :
C:> git update-git-for-windows
ORRR
C:> git update

@dscho
Copy link
Member

dscho commented Oct 17, 2022

with old git version :

As a general rule, I do not support old Git versions. Only new ones. They are the ones with fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants