Git 2.5.2.2 leaves mtab file after uninstall

[Radrik5]

Steps to reproduce:

1. Uninstall Git 2.5.2 using Control Panel
2. Go to C:\Program Files\Git\ or C:\Program Files (x86)\Git\

mtab file is not deleted. Attempt to delete it shows: "The file 'mtab' is a system file. If you remove it, Windows or another program may no longer work correctly.".

Is it safe to delete it? Can uninstaller do it?

[Radrik5]

OS is Windows 7 64 bit.

[dscho]

Should be deleted: git-for-windows/build-extra@bf980fd

[dscho]

Even worse: when I install Git for WIndows 2.5.2(2), there is no /etc/mtab to begin with? How did you get one?

[nalla]

See git-for-windows/build-extra@bf980fd#diff-a34c467933f9f6091a5f960fd70e16deR164 The file is being generated dynamically at some point by msys2. So it might not be there right after install. It is a (symbolic) link to /proc/mounts and somehow msys2 flags it as Windows System File.

As for your user question: Yes it is safe to delete and should be by the uninstaller. Maybe because it is marked as System File it is somehow checked when uninstalling by some sort of UAC?

[Radrik5]

@dscho, it's not /etc/mtab but /mtab. It's created during installation.

[nalla]

Well I can confirm that the mtab file is indeed not in /etc anymore. After a fresh install it is in /. So either that location moved and we have to adapt the uninstaller or there is something amiss when the file is being generated.

[nalla]

@dscho maybe https://github.com/git-for-windows/build-extra/blob/master/post-install.bat#L12 interferes with https://github.com/git-for-windows/build-extra/blob/master/post-install.bat#L41 ?

[rimrul]

When working on #355 I've watched the same thing happen. I think it was already present in git-for-windows/build-extra@0fd86a3.

[dscho]

maybe https://github.com/git-for-windows/build-extra/blob/master/post-install.bat#L12 interferes with https://github.com/git-for-windows/build-extra/blob/master/post-install.bat#L41 ?

Hmm. @nalla Were the post-install scripts expected to be run in /etc/?

[dscho]

Ah no, it is the SYSCONFDIR that is not set correctly... :-(

[nalla]

Ah right! because 03-mtab.post needs that.

[nalla]

I think we have to check every script there - just in case - for other unset variables.

[nalla]

See 99-post-install-cleanup.post, I think that is obsolete because the post-install.bat removes itself?

[dscho]

I think we have to check every script there - just in case - for other unset variables.

Right, I just did.

See 99-post-install-cleanup.post, I think that is obsolete because the post-install.bat removes itself?

No, 99-post-install-cleanup.post cleans up /etc/post-install/, while post-install.bat only removes itself (from the root directory).

[dscho]

@nalla or @rimrul could you quickly give that PR a test? I am actually in the middle of something else I need to finish ASAP...

[nalla]

Installer is available as C:\Users\nalla\Git-2.5.2-testing-64-bit.exe

nalla@dev MINGW64 /usr/src/build-extra/installer (mtab-location)
$ ls /c/Program\ Files/Git/
ReleaseNotes.html  bin/  cmd/  dev/  etc/  git-bash.exe*  git-cmd.exe*  mingw64/  tmp/  unins000.dat  unins000.exe*  usr/

nalla@dev MINGW64 /usr/src/build-extra/installer (mtab-location)
$ ls /c/Program\ Files/Git/etc/
DIR_COLORS        bash.bashrc      fstab  inputrc  networks       package-versions.txt  pki/     profile.d/  services  vimrc
bash.bash_logout  docx2txt.config  hosts  mtab@    nsswitch.conf  pkcs11/               profile  protocols   ssh/

[dscho]

Woot!