Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git 2.6.3 installer error #528

Closed
linquize opened this issue Nov 13, 2015 · 2 comments
Closed

Git 2.6.3 installer error #528

linquize opened this issue Nov 13, 2015 · 2 comments
Labels
duplicate

Comments

@linquize
Copy link

Previously, I installed Git 2.6.2 x64 on Win 7

  1. Launch Git 2.6.3 installer
  2. Confirm to install
  3. Uninstaller shows
  4. UAC prompt
  5. Git 2.6.2 is uninstalled
  6. Git 2.6.3 installing (creating directories)
  7. Error
  8. Quit, installation failed
---------------------------
Git 2.6.3 Setup
---------------------------
Setup was unable to create the directory "C:\Program Files\Git\tmp".
Error 5: Access is denied.
---------------------------
OK   
---------------------------

---------------------------
Error
---------------------------
Setup was not completed.



Please correct the problem and run Setup again.
---------------------------
OK   
---------------------------

UAC prompt is for the uninstaller 2.6.2.
But UAC prompt is not for the installer 2.6.3.

In 2.6.2, UAC prompt starts immediately when starting the installer.
But 2.6.3 does not.

In the meantime, I have to click Run as administrator on 2.6.3 installer as workaround.
@linquize
Copy link
Author

Is it related to git-for-windows/build-extra#86 ?

@linquize linquize mentioned this issue Nov 13, 2015
Closed
@dscho
Copy link
Member

dscho commented Nov 13, 2015

I believe this is now the third ticket describing the very same issue: C:\Program Files\Git\tmp cannot be created after upgrading from 2.6.2:

Please note that the time I spend pointing out duplicates is time I cannot spend on fixing the issue (and I ran out of time today to actually fix bugs because of tending to issues).

@dscho dscho closed this as completed Nov 13, 2015
dscho added a commit to git-for-windows/build-extra that referenced this issue Nov 16, 2015
@dscho
installer: fix privileges (again)
23672af 
Turns out that we had *plenty* of problems with first switching
PrivilegesRequired to 'poweruser' and then to 'lowest': now upgrades
from 2.6.2 to 2.6.3 cannot write to C:\Program Files anymore.

Let's just revert the change and hope that this fixes the upgrade
problem.

In particular, this commit reverts 1f3e1f7 (installer: Change installer
privileges to 'lowest', 2015-10-20) and ec49475 (installer: clarify
required privileges, 2015-10-14).

The deeper explanation is that InnoSetup's `none` and `lowest` settings
are different in behavior, no matter what the release notes made us
believe. The `none` setting will actually respawn an elevated installer
if the current user is in the admin or power user group: see
https://github.com/jrsoftware/issrc/blob/841a86c32/Projects/Main.pas#L2939-L2940
and
https://github.com/jrsoftware/issrc/blob/ea65d280c/Projects/SpawnServer.pas#L217.

Therefore, the `none` setting is actually exactly what we want: users
who have credentials to write to C:\Program Files are presented with an
elevated installer that let's them do precisely that, users without
those rights will be presented with an installer that let's them install
Git into AppData in their home directory.

This fixes git-for-windows/git#523,
git-for-windows/git#526 and
git-for-windows/git#528.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@chrullrich chrullrich mentioned this issue Jul 21, 2016
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dscho @linquize