installer: Note that Windows versions prior to Vista are not supported

[sschuberth]

Signed-off-by: Sebastian Schuberth sschuberth@gmail.com

[dscho]

Thank you! I would have loved to give @PhilipOakley a chance to contribute a patch, but you are too quick for that ;-)

@sschuberth The patch looks good, but as you're the resident InnoSetup expert, I am more comfortable with you merging it...

[sschuberth]

Let's wait for @PhilipOakley and / or @t-b to comment on the wording, and then either @t-b or me can merge.

[dscho]

Fine with me!

[t-b]

Two questions:

• Does any of you seriously test under Windows Vista? Of course it is pretty similiar to Windows 7 so maybe keeping Vista supported is no big deal.
• I've no innosetup knowledge, I'm a NSIS guy, this looks like just a message to inform the user, correct? So we don't actually prevent installation? Fine by me.

[sschuberth]

Does any of you seriously test under Windows Vista? Of course it is pretty similiar to Windows 7 so maybe keeping Vista supported is no big deal.

Not me at least, but I know that a few tools I use are not available before Vista. robocopy and timeout are two of them.

So we don't actually prevent installation?

Correct. The warnings / errors on pre-Vista should be rather minor in general, and a developer might be able to manually fix failed steps after the installation.

The floating point error Philip reported looks like something different, not triggered by simply calling a tool that does not ship before Vista. Let's wait for his reply on the mailing list.

[t-b]

@sschuberth Okay! PR is ACKED!

[t-b]

@sschuberth could you maybe create your topic branches in your fork and not in git-for-windows/sdk? Thanks.

[sschuberth]

OK, will do in the future.