MapView: Copy commit message action #577
Conversation
GitUpKit/Views/GIMapViewController.m
Outdated
| @@ -916,6 +916,11 @@ - (IBAction)editSelectedCommitMessage:(id)sender { | |||
| [self editCommitMessage:commit]; | |||
| } | |||
|
|
|||
| - (IBAction)copySelectedCommitMesssage:(id)sender { | |||
There was a problem hiding this comment.
Messsage -> Message
| @@ -111,6 +111,12 @@ DQ | |||
| <action selector="editSelectedCommitMessage:" target="-2" id="PrK-v7-e6I"/> | |||
| </connections> | |||
| </menuItem> | |||
| <menuItem title="Copy Message…" alternate="YES" keyEquivalent="e" id="LnA-LI-dEb"> | |||
There was a problem hiding this comment.
... is reserved for actions where there will be something the user has to follow up on. There is no followup dialog here so the text should simply be Copy Message.
| - (void)copyCommitMessage:(GCHistoryCommit*)commit { | ||
| NSString* message = _CleanedUpCommitMessage(commit.message); | ||
| [self.windowController showOverlayWithStyle:kGIOverlayStyle_Informational format:NSLocalizedString(@"Commit message copied: \"%@\"", nil), message]; | ||
| [[NSPasteboard generalPasteboard] setString:message forType:NSPasteboardTypeString]; |
There was a problem hiding this comment.
You don't have any -[NSPasteboard declareTypes:owner:] call. It's unlikely to be copying anything to the pasteboard in this case. From the docs: "The type must have been declared by a previous declareTypes:owner: message."
This goes along with my theme of don't make me test your code, please test to make sure it actually copies text...
There was a problem hiding this comment.
@lucasderraugh Heh, my bad. It is ridiculous how different macOS and iOS at some points. Yes, all applications in iOS are sandboxed, so, they can't harm user.
Mmm, I've found a bug in current release app. I think that "testing" code by others is one of the best practices to find bugs.
In this PR I was in hurry, yes. It is one of the core functions that I need ( besides drag & drop, history of file, search in commit view and search in selected range of commits ).
|
Very nice, looks great! |
* kit: mapview copy commit message operation has been added. * kit: mapview contextual menu entry copy selected commit message has been added. * kit: copy selected commit message typo has been fixed. * kit: views map view pasteboard declare types invocation has been added. * kit: views map view contextual menu entry has been renamed.
Uh oh!
There was an error while loading. Please reload this page.