Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anchors to subsections #75

Merged
merged 2 commits into from
Feb 1, 2014

Conversation

simeonwillbanks
Copy link
Contributor

Fixes #74

e.g. /inspect/#log-s

screen shot 2014-01-09 at 7 34 58 pm

e.g. /inspect/#log-s
@randomecho
Copy link
Contributor

If you wanted less markup, you could go with something like:

<h4 id="diff-cached">

@simeonwillbanks
Copy link
Contributor Author

I suggested and used anchors because the h2 tags use anchors.

However, id attributes are fine with me. Should I refactor?

Thanks! 😄

@matthewmccullough
Copy link
Member

@simeonwillbanks Happy to go either way. I don't want to get in the way of this shipping. I'd love this to have less markup, so if that isn't a bunch of work, let's do it. If it is a bunch of work, then lets ship as is.

Thanks for this valuable contribution for accessibility's sake.

@simeonwillbanks
Copy link
Contributor Author

@matthewmccullough You're welcome!

@bry4n
Copy link
Member

bry4n commented Jan 11, 2014

👍

@simeonwillbanks
Copy link
Contributor Author

@matthewmccullough If you have a moment, can you please review my last commit? I hope it's ready to 🚢. If not, let me know.

Thank you for your time! 😄

matthewmccullough pushed a commit that referenced this pull request Feb 1, 2014
@matthewmccullough matthewmccullough merged commit 1d2257f into git:gh-pages Feb 1, 2014
@matthewmccullough
Copy link
Member

@simeonwillbanks Thanks for the reminder. Got the 👍 so it is now 🚢ed!

@simeonwillbanks
Copy link
Contributor Author

@matthewmccullough You're welcome and thank you for 🚢 ing. 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subsection Anchors
4 participants