replace travis ci script with github action #1616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since travis-ci.org has shut down, we no longer have functioning CI for pull requests. Let's translate this to a GitHub Actions workflow. Our set of actual tests is still pretty lousy, but this at least gets our basic sanity checks running again.
Otherwise bundler may complain if ruby-setup's 2.7.x differs from what's in our Gemfile.
This has some security fixes, though none that should impact us. Mostly I want to make sure the bumping process works with CI (it would be nice if we could read the .ruby-version or Gemfile from the CI code; I think it's possible but non-trivial).
peff
commented
Jun 29, 2021
We trigger CI on both "push" and "pull_request". The latter is necessary to get CI results for people opening a PR from their own fork. The former is not strictly necessary, but it's nice to get the PR running as soon as we know about the commits, so that it's often finished by the time you've finished opening up the PR. But this does result in duplicate runs for branches pushed directly into the repo: once when the branch is pushed, and once when the PR is opened. We could get around this by skipping the workflow when we've already got the same job running, but that's more complicated. Let's just drop the "push" trigger. The CI here is pretty fast anyway (at least once the bundler bits are all cached, but that should be the case for any PR that doesn't update gems).
If we omit it, it will use .ruby-version by default, which is exactly what we want! (I had simply cargo-culted the original config).
pedrorijo91
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI is currently broken, since travis-ci.org went away. This replaces it with a GitHub Action.
I wrote this from scratch before realizing that @jnavila had already opened #1562. It's substantially similar, but I broke apart the various steps a bit more. It also has a minor fix to match up the ruby versions in the gemfile and the CI environment. So I'd be inclined to just proceed with this one and close #1562, but if anybody has strong feelings, we can go the other way.
Fixes #1559.