Skip to content

Pay down technical debt #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2025
Merged

Pay down technical debt #2050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26559e8
Drop the work-around for the broken link https://git-scm.com/docs上查看
dscho Sep 4, 2025
5bbd81a
Remove a work-around needed during the transition away from Rails
dscho Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions .github/actions/deploy-to-github-pages/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,25 +85,6 @@ runs:
shell: bash
run: npx -y pagefind@${{ env.PAGEFIND_VERSION }} --site public

- name: Temporarily copy some Rails assets to help the transition
shell: bash
run: |
# To help with the transition from the Rails app to the Hugo/Pagefind site, where
# at least for a while the cached version of git-scm.com might be served via
# Cloudflare, according to the first transition attempt on Sep 20, 2024, potentially
# partially, i.e. _some_ assets might still be cached, _some_ others might not, let's
# copy the most prominent assets to the new page so that, say, the original front page
# won't fail to load the style sheet and Javascript libraries that it needs.
set -x &&
mkdir -p public/assets &&
for f in application-93865c5c820c24f4c599e8b9c544bcd8a0d03260f9b16c9ba80b6a00082112c9.css \
application-f7a750114a26afea236a5cc26f6ff3925a14c5901e9ea9018fb869432d0cbee3.js \
modernize-b3ebe0c31c24f230dc62179d3e1030d2e57a53b1668d9382c0a27dbd44a94beb.js
do
curl -Lfo public/assets/$f https://git-scm.com/assets/$f ||
echo "::error::could not copy $f from https://git-scm.com/" >&2
done

- name: upload GitHub Pages artifact
uses: actions/upload-pages-artifact@v3
with:
Expand Down
7 changes: 0 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,6 @@ jobs:
curl -Lo /tmp/hugo.deb https://github.com/gohugoio/hugo/releases/download/v$HUGO_VERSION/hugo_extended_${HUGO_VERSION}_linux-amd64.deb &&
sudo dpkg -i /tmp/hugo.deb

- name: work around a broken link
# See https://github.com/jnavila/git-manpages-l10n/pull/131;
# A space is missing in "https://git-scm.com/docs上查看"
run: |
sed -i 's,\(href="\(https://git-scm.com/docs\)\)\(上查看\)"\([^>]*>\)\2\3\(</a>\),\1"\4\1\5 \3,p' \
external/docs/content/docs/git/zh_HANS-CN.html

- name: run Hugo to build the pages
run: hugo

Expand Down
Loading