Add idea for git configuration API improvements #7

Merged
merged 3 commits into from Mar 6, 2014

Projects

None yet

2 participants

@mhagger
Contributor
mhagger commented Mar 6, 2014

Needs somebody to volunteer as a co-mentor.

@peff, is this about what you had in mind?

@mhagger mhagger Add idea for git configuration API improvements
This idea evolved out of pull request #6 via a mailing list discussion
[1].

[1] http://article.gmane.org/gmane.comp.version-control.git/242952
d602f22
@peff
Contributor
peff commented Mar 6, 2014

Yes, I think this looks good. I'd be happy to co-mentor, but I see Matthieu has signed up (or you signed him up 😏).

@mhagger mhagger merged commit 7521b80 into master Mar 6, 2014
@mhagger mhagger deleted the config-caching branch Mar 6, 2014
@carlosmn carlosmn pushed a commit to carlosmn/git.github.io that referenced this pull request Feb 19, 2016
@gitster gitster Paying reparation with a new micro for destroying #7.
e.g.

        const char *colon = strchr(name, ':');
        int namelen = colon ? colon - name : strlen(name);

can become

        const char *colon = strchrnul(name, ':');
        int namelen = colon - name;
71344e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment