fix(android): expo fpplan view

[arys]

Summary by CodeRabbit

• Bug Fixes
  • Improved stability and resource management when handling view instances within the Android application.

[coderabbitai]

Walkthrough

This change updates the ExpofpViewManager class in the Android source code to use FplanView instead of SharedFplanView. All relevant method signatures and implementations are adjusted to reference FplanView, including the instantiation of views, parameter types in overridden methods, and the invocation of lifecycle methods such as destroy(). The internal logic for setting view settings remains the same, with only type references updated.

Changes

File(s)	Change Summary
android/src/main/java/com/expofp/ExpofpViewManager.kt	Replaced all references to SharedFplanView with FplanView, updated method signatures, and adjusted instantiations and lifecycle handling accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant Manager as ExpofpViewManager
    participant View as FplanView
    participant Super as Superclass

    Manager->>View: createViewInstance()
    Manager->>View: setSettings(settingsMap)
    Manager->>View: onDropViewInstance(view)
    Manager->>View: view.destroy()
    Manager->>Super: super.onDropViewInstance(view)

Loading

Possibly related PRs

• feat(android): expofp 4.10 #27: Adds an onDropViewInstance override for SharedFplanView in the same class, showing related changes in view management logic.

Poem

In code where floorplans come to play,
A view was swapped, a brighter day!
FplanView now takes the stage,
With cleaner types upon the page.
The manager hops with nimble cheer—
"Out with the old, the new is here!"
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

android/src/main/java/com/expofp/ExpofpViewManager.kt (2)

30-30: View instantiation correctly updated.

The code now properly instantiates a FplanView instead of SharedFplanView. However, you could consider using val instead of var since the variable isn't being reassigned.

-        var view = FplanView(reactContext)
+        val view = FplanView(reactContext)

---

23-23: Consider updating generic type parameter.

The class extends SimpleViewManager<View> but now specifically works with FplanView. For better type safety, consider updating the generic parameter to match.

-class ExpofpViewManager : SimpleViewManager<View>() {
+class ExpofpViewManager : SimpleViewManager<FplanView>() {

This would provide better type safety and eliminate the need for type casting.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c47b79c and 0ade501.

📒 Files selected for processing (1)

• android/src/main/java/com/expofp/ExpofpViewManager.kt (2 hunks)

🔇 Additional comments (3)

android/src/main/java/com/expofp/ExpofpViewManager.kt (3)

17-17: Import change looks good.

The import has been correctly updated from SharedFplanView to FplanView, which aligns with the PR objective to update the codebase to use FplanView.

---

35-35: Method signature properly updated.

The onDropViewInstance method signature has been correctly updated to accept a FplanView parameter instead of SharedFplanView.

---

41-41: Method signature properly updated.

The setSettings method signature has been correctly updated to accept a FplanView parameter instead of SharedFplanView.