Set "can admin" permission on LDAP users and teams correctly #1152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The canAdmin permission is set on a LDAP user, when the user is listed
in
realm.ldap.admins
or is a member of a team listed inrealm.ldap.admins
.This leads to inconsistent and surprising behaviour on the EditUser page
when clicking the "can admin" checkbox. Also, the "can admin" checkbox
is disabled, but not checked, for teams that are listed as admin teams.
The new behaviour implemented in this patch makes users and teams from
LDAP match local ones. That means:
realm.ldap.admins
get the canAdminproperty set if teams are maintained in LDAP.
realm.ldap.admins
get the canAdminproperty set if teams are maintained in LDAP.
member of a team listed in
realm.ldap.admins
.supportsRoleChanges
method for users and teams of theLdapAuthProvider
unconditially returns false if teams aremaintained in LDAP, not only for users and teams listed in
realm.ldap.admins
.is always disabled if teams are maintained in LDAP.