Escape folder names in JGitUtils to allow special characters. #999 #1194
Conversation
martinspielmann
changed the title
| @@ -106,8 +106,21 @@ protected void setupPage(final UserModel userModel) { | |||
| final List<RegistrantAccessPermission> permissions = app().repositories().getUserAccessPermissions(userModel); | |||
|
|
|||
| final Palette<String> teams = new Palette<String>("teams", new ListModel<String>( | |||
| new ArrayList<String>(userTeams)), new CollectionModel<String>(app().users() | |||
| .getAllTeamNames()), new StringChoiceRenderer(), 10, false); | |||
| new ArrayList<String>(userTeams)), new CollectionModel<String>(app().users().getAllTeamNames()), | |||
There was a problem hiding this comment.
Assuming this change is necessary, I would expect we'd need it anywhere we use a palette for teams.
There was a problem hiding this comment.
Ah, you are perfectly right! Just tested and found the same behavior like described in #1135 also on the RepositoryEditPage.
Which alternatives would you prefer:
- add proper escaping to all occurrences of teams within a form, so the submits work like expected
- disallow special chars for team names
I will try to check this also against my local wicket-8 build. Maybe form content is escaped properly by default with a later wicket version..
EDIT: tested with wicket 8 and lot of special chars and it seems like they are causing errors on multiple pages. I would suggest to disallow special chars in team names by adding a validator.
Maybe [a-zA-Z0-9_-] ?
martinspielmann
changed the title
|
I reverted the code on UserEditPage for now, so the pull request only addresses #999 |
String.replaceFirst(String regex, String replacement)works with regex.If a folder name contains chars which are parsed by regex, the replaceFirst will not work as expected.
E.g: if there is a pathString with value "[foo]/bar" and a path having the value "[foo]", then the expected behavior is to result in a string with value "bar".
Fortunately the path can easily be escaped using
Pattern.quote()