Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added javax.activation dependency " #1266

Merged
merged 2 commits into from Nov 7, 2019
Merged

Added javax.activation dependency " #1266

merged 2 commits into from Nov 7, 2019

Conversation

martinspielmann
Copy link
Contributor

thanks to this dependency, one can start gitblit with java 9 without using deprecated internal module --add-modules java.activation

addresses #1262

@martinspielmann
Added javax.activation dependency "
76bbc2d 
thanks to this dependency, one can start gitblit with java 9 without using deprecated internal module --add-modules java.activation
@flaix flaix added this to the 1.9.0 milestone Nov 6, 2019
@flaix
Update to recommended com.sun.activation package.
9560f1b 
Update the dependency to the recommended JAF stand-alone
com.sun.activation:javax.activation:1.2.0
@flaix
Copy link
Member

flaix commented Nov 7, 2019

I don't see this fixing the mentioned #1262. It is a necessary fix to run on Java9+, but the error in #1262 comes from the MxLauncher having problems with Java 9+. That will need a different fix.

@flaix flaix merged commit 4a58ee7 into gitblit-org:master Nov 7, 2019
@martinspielmann martinspielmann deleted the 1262_java9 branch November 9, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martinspielmann @flaix