Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delete portfolio projects #7520

Merged
merged 3 commits into from
Sep 24, 2020

Conversation

chibie
Copy link
Contributor

@chibie chibie commented Sep 24, 2020

Description

Users should be able to delete projects from their portfolio.

Testing

Here's a demonstration video

And a screenshot,
image

@thelostone-mc
Copy link
Member

@chibie could you throw the indent changes into a diff PR ! Would be easier to review

@chibie
Copy link
Contributor Author

chibie commented Sep 24, 2020

@chibie could you throw the indent changes into a diff PR ! Would be easier to review

oh okay sure

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #7520 into master will increase coverage by 7.87%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7520      +/-   ##
==========================================
+ Coverage   18.20%   26.08%   +7.87%     
==========================================
  Files         295      310      +15     
  Lines       30912    31075     +163     
  Branches     4584     4601      +17     
==========================================
+ Hits         5629     8106    +2477     
+ Misses      25272    22685    -2587     
- Partials       11      284     +273     
Impacted Files Coverage Δ
app/dashboard/views.py 10.50% <0.00%> (+2.12%) ⬆️
...arketing/management/commands/new_bounties_email.py 0.00% <0.00%> (-36.37%) ⬇️
app/grants/admin.py 47.22% <0.00%> (-0.86%) ⬇️
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
app/grants/templatetags/grants_extra.py 56.25% <0.00%> (ø)
...rants/management/commands/create_stats_snapshot.py 0.00% <0.00%> (ø)
app/legacy/urls.py 100.00% <0.00%> (ø)
app/kudos/templatetags/kudos_extras.py 70.00% <0.00%> (ø)
app/retail/templatetags/strip_char.py 57.14% <0.00%> (ø)
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bd9fdc...9629df3. Read the comment docs.

@chibie chibie force-pushed the feature/delete-portfolio-item branch from 4851a12 to 122ef2a Compare September 24, 2020 13:15
@chibie
Copy link
Contributor Author

chibie commented Sep 24, 2020

@chibie could you throw the indent changes into a diff PR ! Would be easier to review

@thelostone-mc i have removed the indent changes

@thelostone-mc thelostone-mc merged commit b248b35 into gitcoinco:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants