Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP of celery task routing #7528

Merged
merged 1 commit into from
Sep 24, 2020
Merged

MVP of celery task routing #7528

merged 1 commit into from
Sep 24, 2020

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Sep 24, 2020

Description

Adds the ability to route tasks to different queues, so that marketing tasks (like sending emails) dont get in the way of high priority task queues.

Refers/Fixes

#circle-engineering

https://docs.celeryproject.org/en/stable/userguide/routing.html

Testing

run with

celery worker --app=taskapp --queues=<QUEUE_NAME>

@owocki
Copy link
Contributor Author

owocki commented Sep 24, 2020

there are other ways of probably tuning celery too! @androolloyd let me know if theres a better way of ofrmalizing this

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #7528 into stable will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           stable    #7528   +/-   ##
=======================================
  Coverage   26.00%   26.01%           
=======================================
  Files         309      309           
  Lines       31198    31201    +3     
  Branches     4619     4620    +1     
=======================================
+ Hits         8114     8117    +3     
+ Misses      22805    22800    -5     
- Partials      279      284    +5     
Impacted Files Coverage Δ
app/app/settings.py 80.97% <100.00%> (+0.05%) ⬆️
app/taskapp/celery.py 94.11% <100.00%> (+0.78%) ⬆️
app/quests/views.py 16.22% <0.00%> (ø)
app/dashboard/views.py 10.46% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 39.73% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 145cd9f...1a7c3fe. Read the comment docs.

@owocki
Copy link
Contributor Author

owocki commented Sep 24, 2020

ok added routing support to /home/ubuntu/celery/config on both servbers!

@owocki owocki merged commit 1c45d08 into stable Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant