-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Twitter Verified Combinations & Trust Bonus #7537
Conversation
Codecov Report
@@ Coverage Diff @@
## stable #7537 +/- ##
==========================================
+ Coverage 26.00% 26.92% +0.92%
==========================================
Files 310 310
Lines 31206 33968 +2762
Branches 4618 5675 +1057
==========================================
+ Hits 8114 9146 +1032
- Misses 22813 24429 +1616
- Partials 279 393 +114
Continue to review full report at Codecov.
|
@frankchen07 what's the status on this ? Good to review ? |
@thelostone-mc yes it should be ready. it was to account for kevin's trust bonus field, which would eliminate the need to pull verified lists, we just have to persist the trust bonus score through the CLR calculation (which is done in the latest commit) in this PR. |
@thelostone-mc, ready for review. Big +1 for @octavioamu for sitting with me and helping me figure things out on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codewise lgtm
@frankchen07 was this tested with data or do we need to so that ? |
synced up with @frankchen07 ! it has been tested |
locally verified as well |
Description
Added Twitter Verified handling (f6e3365).
Simplified combination loops for different verification statuses (3c3e18f).
Accounting for Trust Bonus data model, which overwrites and nullifies both previous commits (4d20cb4).
Refers/Fixes
Testing
any
andfor
logic tested with 3 test cases:With 4d20cb4, the trust bonus data model massively simplifies the logic above (and eliminates the need for it).
closes #7821