Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bad tests #7727

Merged
merged 2 commits into from
Oct 23, 2020
Merged

remove bad tests #7727

merged 2 commits into from
Oct 23, 2020

Conversation

danlipert
Copy link
Contributor

Description

This PR removes some tests that a) don't make sense, testing a that a library loads in the case of IPFS or b) I don't think ever worked, as maybe this was missed because of the test failures in a).

Refers/Fixes

Fixes travis

Testing

tested locally

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #7727 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7727      +/-   ##
==========================================
+ Coverage   25.52%   25.61%   +0.08%     
==========================================
  Files         328      325       -3     
  Lines       33044    32703     -341     
  Branches     4919     4848      -71     
==========================================
- Hits         8436     8376      -60     
+ Misses      24320    24035     -285     
- Partials      288      292       +4     
Impacted Files Coverage Δ
...ement/commands/ingest_community_events_calender.py 23.72% <0.00%> (-42.38%) ⬇️
app/dashboard/utils.py 40.40% <0.00%> (-1.39%) ⬇️
app/marketing/models.py 66.78% <0.00%> (-0.37%) ⬇️
app/app/settings.py 81.04% <0.00%> (-0.06%) ⬇️
app/grants/urls.py 100.00% <0.00%> (ø)
app/quests/views.py 16.22% <0.00%> (ø)
app/dashboard/views.py 10.35% <0.00%> (ø)
app/dashboard/models.py 50.01% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 39.73% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d482f4...760e031. Read the comment docs.

@octavioamu
Copy link
Contributor

they use to work but there is a conflict between ipfs-go version and ipfshttpclient, but now as we don't use bounty network I think make sense. Maybe also remove it from the tests packages installation.

@danlipert
Copy link
Contributor Author

they use to work but there is a conflict between ipfs-go version and ipfshttpclient, but now as we don't use bounty network I think make sense. Maybe also remove it from the tests packages installation.

yeah i saw your comment on the ipfshttpclient repo, thanks for doing that. I took a look but not sure why we are getting the conflict now. either way I think its a silly test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants